-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Predicate functions #4109
Conversation
Benchmark ResultMaster commit hash:
|
@@ -214,6 +218,8 @@ WRITE : ( 'W' | 'w' ) ( 'R' | 'r' ) ( 'I' | 'i' ) ( 'T' | 't' ) ( 'E' | 'e' ) ; | |||
|
|||
XOR : ( 'X' | 'x' ) ( 'O' | 'o' ) ( 'R' | 'r' ) ; | |||
|
|||
SINGLE : ( 'S' | 's' ) ( 'I' | 'i' ) ( 'N' | 'n' ) ( 'G' | 'g' ) ( 'L' | 'l' ) ( 'E' | 'e' ) ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make them non-reserved keywords right?
Benchmark ResultMaster commit hash:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4109 +/- ##
==========================================
+ Coverage 84.14% 84.16% +0.02%
==========================================
Files 1316 1321 +5
Lines 51860 51957 +97
Branches 7189 7208 +19
==========================================
+ Hits 43636 43731 +95
- Misses 8069 8071 +2
Partials 155 155 ☔ View full report in Codecov by Sentry. |
(cherry picked from commit ee3816a)
Description
This PR implements the following predicate functions:
all()
any()
none()
single()