Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constant lambda expression evaluation #4098

Merged
merged 2 commits into from
Aug 17, 2024
Merged

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Aug 16, 2024

Description

Fix a bug in evaluating constant lambda expression

Fixes # (issue)

Contributor agreement

Copy link

Benchmark Result

Master commit hash: 8cf9d95fba688c5dbaaefcf1a698e4df2c51234b
Branch commit hash: a98eccd22aaddba827bd053c56067b32bc8619b3

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 677.57 677.29 0.27 (0.04%)
aggregation q28 11278.33 11635.63 -357.29 (-3.07%)
filter q14 151.47 151.68 -0.21 (-0.14%)
filter q15 154.52 153.98 0.54 (0.35%)
filter q16 330.56 326.44 4.12 (1.26%)
filter q17 474.30 472.50 1.79 (0.38%)
filter q18 1972.37 1964.83 7.53 (0.38%)
fixed_size_expr_evaluator q07 568.72 561.85 6.87 (1.22%)
fixed_size_expr_evaluator q08 782.92 770.16 12.77 (1.66%)
fixed_size_expr_evaluator q09 785.86 769.70 16.16 (2.10%)
fixed_size_expr_evaluator q10 265.08 263.93 1.15 (0.44%)
fixed_size_expr_evaluator q11 259.08 260.67 -1.59 (-0.61%)
fixed_size_expr_evaluator q12 258.81 257.97 0.85 (0.33%)
fixed_size_expr_evaluator q13 1492.60 1489.64 2.96 (0.20%)
fixed_size_seq_scan q23 143.27 146.11 -2.84 (-1.95%)
join q31 12.33 11.83 0.49 (4.18%)
ldbc_snb_ic q35 767.39 956.81 -189.42 (-19.80%)
ldbc_snb_ic q36 54.70 45.77 8.93 (19.51%)
ldbc_snb_is q32 10.88 9.62 1.26 (13.09%)
ldbc_snb_is q33 19.22 17.31 1.91 (11.03%)
ldbc_snb_is q34 8.99 8.75 0.24 (2.73%)
multi-rel multi-rel-large-scan 3242.66 2772.30 470.36 (16.97%)
multi-rel multi-rel-lookup 53.12 62.45 -9.33 (-14.93%)
multi-rel multi-rel-small-scan 50.77 55.36 -4.59 (-8.30%)
order_by q25 153.62 157.07 -3.45 (-2.20%)
order_by q26 474.23 490.39 -16.16 (-3.29%)
order_by q27 1429.86 1431.64 -1.78 (-0.12%)
scan_after_filter q01 199.42 196.45 2.97 (1.51%)
scan_after_filter q02 187.06 186.19 0.86 (0.46%)
shortest_path_ldbc100 q39 88.88 89.69 -0.81 (-0.90%)
var_size_expr_evaluator q03 2078.75 2083.42 -4.67 (-0.22%)
var_size_expr_evaluator q04 2268.24 2301.81 -33.57 (-1.46%)
var_size_expr_evaluator q05 2630.34 2689.42 -59.08 (-2.20%)
var_size_expr_evaluator q06 1335.40 1373.25 -37.85 (-2.76%)
var_size_seq_scan q19 1491.02 1495.80 -4.78 (-0.32%)
var_size_seq_scan q20 3191.55 3142.97 48.58 (1.55%)
var_size_seq_scan q21 2413.07 2417.15 -4.08 (-0.17%)
var_size_seq_scan q22 135.87 138.22 -2.35 (-1.70%)

@andyfengHKU andyfengHKU requested a review from ray6080 August 17, 2024 03:06
Copy link

Benchmark Result

Master commit hash: f6ef3d5bd1aa10d4bff3bf8b1d42d8254783b8eb
Branch commit hash: 308a5c3a6afe919376d03d213e0369c8169c5981

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 677.12 688.55 -11.43 (-1.66%)
aggregation q28 11469.54 12153.03 -683.49 (-5.62%)
filter q14 154.59 150.38 4.21 (2.80%)
filter q15 151.63 154.55 -2.92 (-1.89%)
filter q16 326.93 327.72 -0.79 (-0.24%)
filter q17 471.78 472.19 -0.41 (-0.09%)
filter q18 1977.65 1950.87 26.78 (1.37%)
fixed_size_expr_evaluator q07 563.81 562.00 1.81 (0.32%)
fixed_size_expr_evaluator q08 787.10 775.44 11.66 (1.50%)
fixed_size_expr_evaluator q09 773.11 776.02 -2.91 (-0.37%)
fixed_size_expr_evaluator q10 264.66 268.98 -4.32 (-1.61%)
fixed_size_expr_evaluator q11 260.28 260.07 0.21 (0.08%)
fixed_size_expr_evaluator q12 258.13 258.63 -0.49 (-0.19%)
fixed_size_expr_evaluator q13 1504.19 1507.67 -3.48 (-0.23%)
fixed_size_seq_scan q23 146.53 145.83 0.69 (0.48%)
join q31 12.39 12.70 -0.30 (-2.38%)
ldbc_snb_ic q35 773.09 1096.74 -323.65 (-29.51%)
ldbc_snb_ic q36 49.84 52.09 -2.25 (-4.32%)
ldbc_snb_is q32 10.17 9.06 1.12 (12.31%)
ldbc_snb_is q33 17.71 17.56 0.15 (0.84%)
ldbc_snb_is q34 8.68 7.72 0.97 (12.54%)
multi-rel multi-rel-large-scan 2860.55 2923.36 -62.81 (-2.15%)
multi-rel multi-rel-lookup 61.19 60.87 0.32 (0.53%)
multi-rel multi-rel-small-scan 52.44 52.12 0.32 (0.61%)
order_by q25 161.00 159.76 1.24 (0.77%)
order_by q26 474.11 482.52 -8.40 (-1.74%)
order_by q27 1438.21 1434.93 3.28 (0.23%)
scan_after_filter q01 203.23 199.64 3.59 (1.80%)
scan_after_filter q02 191.19 186.12 5.06 (2.72%)
shortest_path_ldbc100 q39 112.22 114.95 -2.73 (-2.38%)
var_size_expr_evaluator q03 2091.25 2079.21 12.04 (0.58%)
var_size_expr_evaluator q04 2282.12 2284.18 -2.07 (-0.09%)
var_size_expr_evaluator q05 2749.53 2631.78 117.75 (4.47%)
var_size_expr_evaluator q06 1369.98 1333.52 36.46 (2.73%)
var_size_seq_scan q19 1498.08 1469.86 28.22 (1.92%)
var_size_seq_scan q20 3235.72 3127.58 108.14 (3.46%)
var_size_seq_scan q21 2458.58 2410.91 47.67 (1.98%)
var_size_seq_scan q22 135.89 131.71 4.18 (3.17%)

@andyfengHKU andyfengHKU merged commit 8bb49cf into master Aug 17, 2024
@andyfengHKU andyfengHKU deleted the fold-lambda-expr branch August 17, 2024 04:13
ray6080 pushed a commit that referenced this pull request Oct 11, 2024
* Fix constant lambda expr evaluation

* Run clang-format

---------

Co-authored-by: CI Bot <andyfengHKU@users.noreply.github.com>
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
* Fix constant lambda expr evaluation

* Run clang-format

---------

Co-authored-by: CI Bot <andyfengHKU@users.noreply.github.com>
(cherry picked from commit 8bb49cf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants