Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto checkpoint when closing db #4075

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Auto checkpoint when closing db #4075

merged 1 commit into from
Aug 14, 2024

Conversation

ray6080
Copy link
Contributor

@ray6080 ray6080 commented Aug 14, 2024

Description

Set forceCheckpointOnClose to true.

Copy link

Benchmark Result

Master commit hash: 9b61d03b78644e650f346e79ad5b45960a72541e
Branch commit hash: dcf36ae39b46e65012c8c74fa990f0312d94bd30

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 676.05 676.27 -0.22 (-0.03%)
aggregation q28 11672.89 10957.58 715.32 (6.53%)
filter q14 154.53 153.04 1.48 (0.97%)
filter q15 155.27 151.38 3.89 (2.57%)
filter q16 339.96 335.40 4.56 (1.36%)
filter q17 474.78 473.05 1.73 (0.37%)
filter q18 1958.89 1951.71 7.18 (0.37%)
fixed_size_expr_evaluator q07 568.68 567.86 0.81 (0.14%)
fixed_size_expr_evaluator q08 781.77 772.86 8.91 (1.15%)
fixed_size_expr_evaluator q09 771.31 772.07 -0.75 (-0.10%)
fixed_size_expr_evaluator q10 264.77 264.82 -0.05 (-0.02%)
fixed_size_expr_evaluator q11 258.97 259.89 -0.92 (-0.35%)
fixed_size_expr_evaluator q12 258.26 258.57 -0.31 (-0.12%)
fixed_size_expr_evaluator q13 1496.24 1502.40 -6.17 (-0.41%)
fixed_size_seq_scan q23 142.97 143.80 -0.83 (-0.58%)
join q31 12.26 13.05 -0.79 (-6.05%)
ldbc_snb_ic q35 766.20 777.29 -11.09 (-1.43%)
ldbc_snb_ic q36 46.77 45.35 1.42 (3.13%)
ldbc_snb_is q32 9.46 9.81 -0.35 (-3.62%)
ldbc_snb_is q33 18.85 19.35 -0.50 (-2.57%)
ldbc_snb_is q34 8.17 8.53 -0.36 (-4.26%)
multi-rel multi-rel-large-scan 2738.63 3212.53 -473.90 (-14.75%)
multi-rel multi-rel-lookup 47.39 66.46 -19.07 (-28.70%)
multi-rel multi-rel-small-scan 55.76 73.70 -17.93 (-24.33%)
order_by q25 154.00 154.60 -0.60 (-0.39%)
order_by q26 468.76 470.76 -2.00 (-0.43%)
order_by q27 1430.02 1425.13 4.89 (0.34%)
scan_after_filter q01 197.18 197.79 -0.61 (-0.31%)
scan_after_filter q02 185.52 186.71 -1.18 (-0.63%)
shortest_path_ldbc100 q39 155.41 163.80 -8.39 (-5.12%)
var_size_expr_evaluator q03 2076.14 2066.73 9.41 (0.46%)
var_size_expr_evaluator q04 2232.61 2261.69 -29.09 (-1.29%)
var_size_expr_evaluator q05 2675.94 2682.04 -6.09 (-0.23%)
var_size_expr_evaluator q06 1353.33 1348.15 5.18 (0.38%)
var_size_seq_scan q19 1483.52 1481.76 1.76 (0.12%)
var_size_seq_scan q20 3138.32 3154.08 -15.76 (-0.50%)
var_size_seq_scan q21 2390.96 2412.77 -21.81 (-0.90%)
var_size_seq_scan q22 135.69 134.31 1.38 (1.03%)

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (9b61d03) to head (cc92aa9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4075      +/-   ##
==========================================
- Coverage   84.53%   84.05%   -0.48%     
==========================================
  Files        1300     1300              
  Lines       51048    51048              
  Branches     7058     7063       +5     
==========================================
- Hits        43151    42910     -241     
- Misses       7758     7999     +241     
  Partials      139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ray6080 ray6080 merged commit 1437af9 into master Aug 14, 2024
23 checks passed
@ray6080 ray6080 deleted the checkpoint-when-close branch August 14, 2024 02:51
ray6080 added a commit that referenced this pull request Aug 14, 2024
@ray6080 ray6080 changed the title Auto checkpoint when close db Auto checkpoint when closing db Aug 14, 2024
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants