Extension installation rework #4066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acquamarin
force-pushed
the
extension-installation-fix
branch
from
f8ecb2d to
e735a72
Compare
Benchmark ResultMaster commit hash:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4066 +/- ##
==========================================
+ Coverage 84.12% 84.14% +0.01%
==========================================
Files 1314 1316 +2
Lines 51789 51860 +71
Branches 7187 7190 +3
==========================================
+ Hits 43567 43636 +69
- Misses 8067 8069 +2
Partials 155 155 ☔ View full report in Codecov by Sentry. |
Benchmark ResultMaster commit hash:
|
Benchmark ResultMaster commit hash:
|
Benchmark ResultMaster commit hash:
|
ray6080
approved these changes
Aug 22, 2024
| @@ -171,7 +171,6 @@ extension-test-build: | |||
| $(call run-cmake-release, \ | |||
| -DBUILD_EXTENSIONS="httpfs;duckdb;json;postgres;sqlite" \ | |||
| -DBUILD_EXTENSION_TESTS=TRUE \ | |||
| -DENABLE_ADDRESS_SANITIZER=TRUE \ | |||
There was a problem hiding this comment.
Why remove asan from extension test?
There was a problem hiding this comment.
duckdb doesn't compile with asan, if we compile with asan linking with duckdb will cause a linking error in windows.
acquamarin
force-pushed
the
extension-installation-fix
branch
from
c8320d5 to
bb4fb2e
Compare
Benchmark ResultMaster commit hash:
|
ted-wq-x
pushed a commit
to ted-wq-x/kuzu
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit ef4e729)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the extension installation framework.
For extension which has dependencies (for example: duckdb), it should provide an additional loader and installer:
installer: installs the necessary dependency libraries.
loader: loads the necesssary dependency libraries.