Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force cast when scanning #4041

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Force cast when scanning #4041

merged 3 commits into from
Aug 7, 2024

Conversation

mxwli
Copy link
Contributor

@mxwli mxwli commented Aug 7, 2024

Mainly for usability's sake.

Contributor agreement

@mxwli mxwli requested a review from andyfengHKU August 7, 2024 16:25
tools/python_api/test/test_scan_pandas.py Outdated Show resolved Hide resolved
@mxwli mxwli force-pushed the implicit-cast-change branch from 8d0316a to b8891da Compare August 7, 2024 17:12
@mxwli mxwli changed the title Allow implicit casting from STRING to any type Force cast when scanning Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Benchmark Result

Master commit hash: 7139a6a92aaf66166602c58f0afedc83fab783c4
Branch commit hash: 4a04fcac2880b972ad095fe446b5efdf81e16491

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 675.45 675.13 0.31 (0.05%)
aggregation q28 11810.00 11729.63 80.37 (0.69%)
filter q14 149.93 150.67 -0.74 (-0.49%)
filter q15 159.79 151.85 7.93 (5.22%)
filter q16 339.85 331.11 8.74 (2.64%)
filter q17 473.20 475.82 -2.62 (-0.55%)
filter q18 1956.26 1961.21 -4.94 (-0.25%)
fixed_size_expr_evaluator q07 570.31 566.85 3.46 (0.61%)
fixed_size_expr_evaluator q08 800.71 776.11 24.59 (3.17%)
fixed_size_expr_evaluator q09 784.60 779.11 5.49 (0.70%)
fixed_size_expr_evaluator q10 264.62 266.72 -2.11 (-0.79%)
fixed_size_expr_evaluator q11 259.76 260.32 -0.55 (-0.21%)
fixed_size_expr_evaluator q12 263.95 258.80 5.15 (1.99%)
fixed_size_expr_evaluator q13 1503.51 1501.45 2.07 (0.14%)
fixed_size_seq_scan q23 162.72 140.44 22.28 (15.86%)
join q31 52.91 48.92 3.99 (8.16%)
ldbc_snb_ic q35 3555.43 3567.69 -12.25 (-0.34%)
ldbc_snb_ic q36 137.08 131.64 5.43 (4.13%)
ldbc_snb_is q32 10.69 10.29 0.40 (3.92%)
ldbc_snb_is q33 98.05 94.38 3.67 (3.89%)
ldbc_snb_is q34 99.19 89.88 9.31 (10.36%)
multi-rel multi-rel-large-scan 3390.71 2761.02 629.69 (22.81%)
multi-rel multi-rel-lookup 62.20 72.11 -9.91 (-13.74%)
multi-rel multi-rel-small-scan 53.89 71.32 -17.42 (-24.43%)
order_by q25 156.47 157.09 -0.62 (-0.39%)
order_by q26 482.25 480.98 1.26 (0.26%)
order_by q27 1430.91 1424.57 6.34 (0.45%)
scan_after_filter q01 198.51 197.52 0.99 (0.50%)
scan_after_filter q02 190.41 185.85 4.55 (2.45%)
shortest_path_ldbc100 q39 76.42 87.51 -11.09 (-12.67%)
var_size_expr_evaluator q03 2072.33 2070.41 1.92 (0.09%)
var_size_expr_evaluator q04 2264.17 2265.51 -1.34 (-0.06%)
var_size_expr_evaluator q05 2630.55 2627.90 2.65 (0.10%)
var_size_expr_evaluator q06 1376.14 1357.48 18.66 (1.37%)
var_size_seq_scan q19 1492.59 1489.80 2.79 (0.19%)
var_size_seq_scan q20 3123.12 3142.24 -19.12 (-0.61%)
var_size_seq_scan q21 2399.20 2411.98 -12.78 (-0.53%)
var_size_seq_scan q22 135.82 134.69 1.14 (0.84%)

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.16%. Comparing base (7139a6a) to head (1666b32).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4041   +/-   ##
=======================================
  Coverage   85.16%   85.16%           
=======================================
  Files        1297     1297           
  Lines       50536    50538    +2     
  Branches     6956     6959    +3     
=======================================
+ Hits        43037    43041    +4     
+ Misses       7368     7367    -1     
+ Partials      131      130    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 7, 2024

Benchmark Result

Master commit hash: 8781c0b454313b51ecbfee7b094fc0250c26d7c5
Branch commit hash: 6ecd67e9a20ae9cdd433070c7ccb76e07bcb303c

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 685.49 684.79 0.69 (0.10%)
aggregation q28 11710.86 11734.49 -23.63 (-0.20%)
filter q14 159.35 159.83 -0.48 (-0.30%)
filter q15 160.56 159.22 1.34 (0.84%)
filter q16 336.41 340.16 -3.74 (-1.10%)
filter q17 480.33 483.29 -2.96 (-0.61%)
filter q18 1950.33 1952.32 -2.00 (-0.10%)
fixed_size_expr_evaluator q07 574.30 572.03 2.27 (0.40%)
fixed_size_expr_evaluator q08 789.41 781.89 7.52 (0.96%)
fixed_size_expr_evaluator q09 779.20 786.48 -7.28 (-0.93%)
fixed_size_expr_evaluator q10 275.57 273.13 2.44 (0.89%)
fixed_size_expr_evaluator q11 267.26 268.33 -1.06 (-0.40%)
fixed_size_expr_evaluator q12 266.63 267.04 -0.41 (-0.15%)
fixed_size_expr_evaluator q13 1504.84 1508.14 -3.31 (-0.22%)
fixed_size_seq_scan q23 151.37 151.72 -0.35 (-0.23%)
join q31 39.48 49.32 -9.84 (-19.95%)
ldbc_snb_ic q35 3627.79 3682.00 -54.21 (-1.47%)
ldbc_snb_ic q36 126.08 120.15 5.93 (4.93%)
ldbc_snb_is q32 10.31 10.68 -0.36 (-3.41%)
ldbc_snb_is q33 92.43 96.26 -3.83 (-3.98%)
ldbc_snb_is q34 90.41 97.64 -7.24 (-7.41%)
multi-rel multi-rel-large-scan 2864.29 2958.47 -94.17 (-3.18%)
multi-rel multi-rel-lookup 78.36 71.80 6.57 (9.15%)
multi-rel multi-rel-small-scan 63.60 63.99 -0.39 (-0.62%)
order_by q25 168.02 169.49 -1.47 (-0.87%)
order_by q26 489.14 485.52 3.62 (0.75%)
order_by q27 1438.92 1434.78 4.14 (0.29%)
scan_after_filter q01 205.47 205.06 0.41 (0.20%)
scan_after_filter q02 194.21 196.04 -1.83 (-0.94%)
shortest_path_ldbc100 q39 80.93 79.53 1.41 (1.77%)
var_size_expr_evaluator q03 2091.01 2083.87 7.14 (0.34%)
var_size_expr_evaluator q04 2270.73 2274.94 -4.21 (-0.19%)
var_size_expr_evaluator q05 2578.98 2560.46 18.52 (0.72%)
var_size_expr_evaluator q06 1363.51 1363.10 0.41 (0.03%)
var_size_seq_scan q19 1492.83 1486.62 6.20 (0.42%)
var_size_seq_scan q20 3166.40 3172.72 -6.31 (-0.20%)
var_size_seq_scan q21 2437.22 2437.28 -0.06 (-0.00%)
var_size_seq_scan q22 136.72 136.74 -0.02 (-0.01%)

@mxwli mxwli merged commit c6ae098 into master Aug 7, 2024
24 checks passed
@mxwli mxwli deleted the implicit-cast-change branch August 7, 2024 21:23
ray6080 pushed a commit that referenced this pull request Aug 14, 2024
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants