Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply zone map to rel scan #3573

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Apply zone map to rel scan #3573

merged 2 commits into from
Jun 5, 2024

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Jun 3, 2024 •
edited
Loading

Description

This PR applies zone map when scanning rel table data. A test is failing due to #3572

Fixes # (issue)

Contributor agreement

@andyfengHKU andyfengHKU requested a review from ray6080 June 3, 2024 04:51
ray6080
ray6080 approved these changes Jun 4, 2024
View reviewed changes
src/include/processor/operator/scan/scan_rel_table.h Outdated Show resolved Hide resolved
src/include/storage/store/node_table.h Outdated Show resolved Hide resolved
src/include/storage/store/table.h Outdated Show resolved Hide resolved
src/include/processor/operator/scan/scan_rel_table.h Show resolved Hide resolved
src/storage/store/column.cpp Outdated Show resolved Hide resolved
src/storage/store/rel_table_data.cpp Show resolved Hide resolved
src/storage/store/node_table_data.cpp Show resolved Hide resolved
@andyfengHKU andyfengHKU force-pushed the apply-zone-map-to-rel-scan branch from 807c98e to 2dce68e Compare June 5, 2024 02:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Benchmark Result

Master commit hash: 35eee929fc96706a163dc03b4f7706978d78ccb8
Branch commit hash: c6b4fc2917e63b2070ff7ed3cbf1bca8bb1f1d1f

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 642.89 652.25 -9.36 (-1.43%)
aggregation q28 12847.73 13072.70 -224.98 (-1.72%)
filter q14 127.51 132.51 -5.00 (-3.77%)
filter q15 122.39 137.05 -14.66 (-10.70%)
filter q16 304.88 310.13 -5.25 (-1.69%)
filter q17 447.82 450.91 -3.09 (-0.69%)
filter q18 1965.55 1953.11 12.44 (0.64%)
fixed_size_expr_evaluator q07 564.21 571.74 -7.53 (-1.32%)
fixed_size_expr_evaluator q08 791.76 799.51 -7.75 (-0.97%)
fixed_size_expr_evaluator q09 792.23 796.27 -4.04 (-0.51%)
fixed_size_expr_evaluator q10 240.07 247.65 -7.58 (-3.06%)
fixed_size_expr_evaluator q11 236.54 242.89 -6.35 (-2.62%)
fixed_size_expr_evaluator q12 233.76 241.68 -7.92 (-3.28%)
fixed_size_expr_evaluator q13 1478.76 1482.80 -4.04 (-0.27%)
fixed_size_seq_scan q23 120.04 123.69 -3.65 (-2.95%)
join q29 710.09 704.94 5.15 (0.73%)
join q30 1417.51 1395.87 21.64 (1.55%)
join q31 46.00 38.77 7.24 (18.67%)
ldbc_snb_ic q35 3401.19 3223.53 177.66 (5.51%)
ldbc_snb_ic q36 131.54 131.44 0.10 (0.08%)
ldbc_snb_is q32 13.29 11.62 1.68 (14.43%)
ldbc_snb_is q33 94.11 98.06 -3.95 (-4.03%)
ldbc_snb_is q34 93.57 100.23 -6.66 (-6.64%)
order_by q25 126.30 132.79 -6.49 (-4.89%)
order_by q26 433.22 446.48 -13.26 (-2.97%)
order_by q27 1380.76 1423.13 -42.36 (-2.98%)
scan_after_filter q01 166.02 174.51 -8.49 (-4.87%)
scan_after_filter q02 148.45 155.28 -6.82 (-4.39%)
shortest_path_ldbc100 q39 57.97 55.90 2.07 (3.71%)
var_size_expr_evaluator q03 2055.28 2049.14 6.14 (0.30%)
var_size_expr_evaluator q04 2235.74 2273.39 -37.65 (-1.66%)
var_size_expr_evaluator q05 2572.60 2545.55 27.05 (1.06%)
var_size_expr_evaluator q06 1405.32 1394.92 10.40 (0.75%)
var_size_seq_scan q19 1437.40 1468.85 -31.45 (-2.14%)
var_size_seq_scan q20 3047.01 3045.50 1.50 (0.05%)
var_size_seq_scan q21 2374.48 2375.60 -1.11 (-0.05%)
var_size_seq_scan q22 129.37 131.82 -2.45 (-1.86%)

@andyfengHKU andyfengHKU force-pushed the apply-zone-map-to-rel-scan branch from 6b016eb to fd57c41 Compare June 5, 2024 02:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Benchmark Result

Master commit hash: 35eee929fc96706a163dc03b4f7706978d78ccb8
Branch commit hash: 54ae530dc1dc12ee6325ae342260db22291ddd4e

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 653.88 652.25 1.64 (0.25%)
aggregation q28 12411.52 13072.70 -661.19 (-5.06%)
filter q14 124.03 132.51 -8.48 (-6.40%)
filter q15 127.53 137.05 -9.52 (-6.95%)
filter q16 302.69 310.13 -7.44 (-2.40%)
filter q17 444.40 450.91 -6.52 (-1.45%)
filter q18 1915.77 1953.11 -37.34 (-1.91%)
fixed_size_expr_evaluator q07 567.56 571.74 -4.18 (-0.73%)
fixed_size_expr_evaluator q08 793.71 799.51 -5.80 (-0.73%)
fixed_size_expr_evaluator q09 791.21 796.27 -5.06 (-0.64%)
fixed_size_expr_evaluator q10 238.86 247.65 -8.79 (-3.55%)
fixed_size_expr_evaluator q11 233.79 242.89 -9.10 (-3.75%)
fixed_size_expr_evaluator q12 234.46 241.68 -7.22 (-2.99%)
fixed_size_expr_evaluator q13 1480.99 1482.80 -1.81 (-0.12%)
fixed_size_seq_scan q23 116.97 123.69 -6.73 (-5.44%)
join q29 711.64 704.94 6.69 (0.95%)
join q30 1471.60 1395.87 75.73 (5.43%)
join q31 49.94 38.77 11.17 (28.83%)
ldbc_snb_ic q35 3298.07 3223.53 74.54 (2.31%)
ldbc_snb_ic q36 131.25 131.44 -0.19 (-0.14%)
ldbc_snb_is q32 11.10 11.62 -0.52 (-4.46%)
ldbc_snb_is q33 100.07 98.06 2.02 (2.06%)
ldbc_snb_is q34 97.37 100.23 -2.86 (-2.85%)
order_by q25 124.99 132.79 -7.80 (-5.87%)
order_by q26 434.05 446.48 -12.42 (-2.78%)
order_by q27 1388.14 1423.13 -34.99 (-2.46%)
scan_after_filter q01 163.41 174.51 -11.11 (-6.36%)
scan_after_filter q02 146.60 155.28 -8.68 (-5.59%)
shortest_path_ldbc100 q39 58.77 55.90 2.87 (5.14%)
var_size_expr_evaluator q03 2052.58 2049.14 3.44 (0.17%)
var_size_expr_evaluator q04 2230.95 2273.39 -42.43 (-1.87%)
var_size_expr_evaluator q05 2575.64 2545.55 30.09 (1.18%)
var_size_expr_evaluator q06 1416.81 1394.92 21.89 (1.57%)
var_size_seq_scan q19 1430.93 1468.85 -37.93 (-2.58%)
var_size_seq_scan q20 3064.47 3045.50 18.96 (0.62%)
var_size_seq_scan q21 2363.58 2375.60 -12.02 (-0.51%)
var_size_seq_scan q22 129.89 131.82 -1.94 (-1.47%)

@andyfengHKU andyfengHKU marked this pull request as ready for review June 5, 2024 03:17
@andyfengHKU andyfengHKU merged commit 5938561 into master Jun 5, 2024
@andyfengHKU andyfengHKU deleted the apply-zone-map-to-rel-scan branch June 5, 2024 03:17
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
@andyfengHKU
Apply zone map to rel scan (kuzudb#3573)
39cae26 
* Apply zone map to scan rel table

* Run clang-format

---------

Co-authored-by: CI Bot <andyfengHKU@users.noreply.github.com>

(cherry picked from commit 5938561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyfengHKU @ray6080