Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled test for 3524 #3546

Merged
merged 2 commits into from
May 28, 2024
Merged

Fix disabled test for 3524 #3546

merged 2 commits into from
May 28, 2024

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented May 27, 2024

Description

This PR turns some of the disabled test due to #3524. Tests related to join order and RDF are still failing.

Fixes # (issue)

Contributor agreement

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (2518d65) to head (6278acb).
Report is 19 commits behind head on master.

Current head 6278acb differs from pull request most recent head ce17b00

Please upload reports for the commit ce17b00 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3546      +/-   ##
==========================================
- Coverage   90.01%   88.92%   -1.10%     
==========================================
  Files        1190     1201      +11     
  Lines       42956    43991    +1035     
==========================================
+ Hits        38668    39120     +452     
- Misses       4288     4871     +583     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

src/include/storage/store/table.h Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU force-pushed the fix-diabled-test-for-3524 branch from 171a50d to 78ed700 Compare May 28, 2024 05:17
@andyfengHKU andyfengHKU force-pushed the fix-diabled-test-for-3524 branch from c70ed29 to d2528df Compare May 28, 2024 06:08
@andyfengHKU andyfengHKU merged commit 4e730a9 into master May 28, 2024
@andyfengHKU andyfengHKU deleted the fix-diabled-test-for-3524 branch May 28, 2024 06:44
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
* Fix disabled test in 3524

* Run clang-format

---------

Co-authored-by: CI Bot <andyfengHKU@users.noreply.github.com>
(cherry picked from commit 4e730a9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants