Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of hash slots on 32bit env #3460

Merged
merged 2 commits into from
May 8, 2024
Merged

Fix calculation of hash slots on 32bit env #3460

merged 2 commits into from
May 8, 2024

Conversation

acquamarin
Copy link
Collaborator

@acquamarin acquamarin commented May 8, 2024

We require the number of hash slots to be power of 2 because we compute the block mask based on that value:

numSlotsPerBlockLog2 = std::log2(numSlotsPerBlock);
 slotIdxInBlockMask =
        common::BitmaskUtils::all1sMaskForLeastSignificantBits(numSlotsPerBlockLog2);

@andyfengHKU andyfengHKU requested a review from ray6080 May 8, 2024 03:55
@acquamarin acquamarin merged commit 0b8170c into master May 8, 2024
17 checks passed
@acquamarin acquamarin deleted the fix-hash-32 branch May 8, 2024 13:22
ted-wq-x pushed a commit to ted-wq-x/kuzu that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants