Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework multiple query result #3191

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Rework multiple query result #3191

merged 3 commits into from
Apr 4, 2024

Conversation

hououou
Copy link
Collaborator

@hououou hououou commented Apr 1, 2024

Rework query results of multiple query statements. We use the list chain of query results for multiple query statements. To get each query result, we could loop to get each query result. Implement the following interfaces:

  • toString() : return the string of the first query result.
  • hasNextQueryResult(): return true if we have more query results otherwise false
  • getNextQueryResult(): return the next query result

Note the query result is the result for each individual query statement.
TODO: We should expose hasNextQueryResult()``getNextQueryResult() in java/nodejs/rust/python apis.

@hououou hououou requested a review from andyfengHKU April 1, 2024 20:57
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (6b1d45a) to head (570cd55).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3191      +/-   ##
==========================================
- Coverage   92.19%   92.19%   -0.01%     
==========================================
  Files        1157     1156       -1     
  Lines       44010    43999      -11     
==========================================
- Hits        40576    40563      -13     
- Misses       3434     3436       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hououou hououou force-pushed the multiple_query_results branch from 87449d5 to 20aa074 Compare April 1, 2024 23:25
Copy link
Contributor

@andyfengHKU andyfengHKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test file based e2e tests.

src/main/client_context.cpp Outdated Show resolved Hide resolved
src/include/main/query_result.h Outdated Show resolved Hide resolved
@hououou hououou requested a review from andyfengHKU April 3, 2024 17:06
@hououou hououou merged commit ec6e309 into master Apr 4, 2024
20 checks passed
@hououou hououou deleted the multiple_query_results branch April 4, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants