Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added customizable delay before displaying progress bar #3092

Merged
merged 12 commits into from
Mar 22, 2024
Merged

Added customizable delay before displaying progress bar #3092

merged 12 commits into from
Mar 22, 2024

Conversation

MSebanc
Copy link
Collaborator

@MSebanc MSebanc commented Mar 19, 2024

I have read and agree to the CLA of the Kuzu repository.

@MSebanc
Added delay before printing progress bar
8e0c81b 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc MSebanc requested a review from andyfengHKU March 19, 2024 23:11
MSebanc added 3 commits March 19, 2024 16:14
@MSebanc
Format fixes
cf6329f 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Added tests
160cc6f 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Added memory header
e00c734 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc MSebanc marked this pull request as draft March 19, 2024 23:26
MSebanc and others added 3 commits March 20, 2024 09:59
@MSebanc
Config default value
c279f7a 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Fixed query timer
307e724 
I have read and agree to the CLA of the Kuzu repository.
@MSebanc
Changed extension version to 0.2.1
9bcbca2
andyfengHKU
andyfengHKU approved these changes Mar 21, 2024
View reviewed changes
src/common/task_system/progress_bar.cpp Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.42857% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.90%. Comparing base (d4b261b) to head (8877036).
Report is 1 commits behind head on master.

Files Patch % Lines
src/common/task_system/progress_bar.cpp 94.44% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3092      +/-   ##
==========================================
- Coverage   91.91%   91.90%   -0.02%     
==========================================
  Files        1169     1169              
  Lines       43736    43759      +23     
==========================================
+ Hits        40202    40217      +15     
- Misses       3534     3542       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MSebanc MSebanc marked this pull request as ready for review March 22, 2024 19:03
@MSebanc MSebanc merged commit 8f37501 into master Mar 22, 2024
32 of 33 checks passed
@MSebanc MSebanc deleted the ProgressBarTimer branch March 22, 2024 19:04
ray6080 pushed a commit that referenced this pull request Mar 23, 2024
@MSebanc @ray6080
Added customizable delay before displaying progress bar (#3092)
bc0d4b5 
I have read and agree to the CLA of the Kuzu repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyfengHKU andyfengHKU andyfengHKU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSebanc @andyfengHKU @mewim