-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix IMPORT_DATABASE path #3063
fix IMPORT_DATABASE path #3063
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3063 +/- ##
=======================================
Coverage 91.89% 91.90%
=======================================
Files 1169 1169
Lines 43759 43764 +5
=======================================
+ Hits 40214 40220 +6
+ Misses 3545 3544 -1 ☔ View full report in Codecov by Sentry. |
aedf08c
to
048ad70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this PR is to fix a bug. But I don't see a test reproducing that bug.
02f8798
to
5bd546e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, we should parse the csvOptions when exporting. If the csvOptions have special characters, we should escape/quote
0a27ac7
to
9678007
Compare
d11219b
to
73949ed
Compare
When we execute the export database statement
"export database 'path1' "
, we will export data in a directory'path1'
, along with csv cyphers, data cyphers, and macro cyphers for import database later. The copy statement is just likecopy xx from path1/tablename
. Assume we move this exported data directory to other directories, or to other platforms, and then want to import it withimport database 'path2'.
Then the path1 in copy statement is not correct. This PR is to replace the path in copy statements with path2, i.e., the bounded import file path.