Draft example of arithmetic function refactor #3049
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3049 +/- ##
=======================================
Coverage 93.24% 93.25%
=======================================
Files 1133 1133
Lines 43117 43132 +15
=======================================
+ Hits 40204 40221 +17
+ Misses 2913 2911 -2 ☔ View full report in Codecov by Sentry. |
acquamarin
approved these changes
Mar 18, 2024
| @@ -5,6 +5,10 @@ | |||
| namespace kuzu { | |||
| namespace catalog { | |||
|
|
|||
| ScalarFunctionCatalogEntry::ScalarFunctionCatalogEntry( | |||
There was a problem hiding this comment.
I don't think you need an additional constructor for const char* name. implicit cast will happen when the user provides name as a const char*.
| @@ -12,6 +12,7 @@ class ScalarFunctionCatalogEntry final : public FunctionCatalogEntry { | |||
| // constructors | |||
| //===--------------------------------------------------------------------===// | |||
| ScalarFunctionCatalogEntry() = default; | |||
| ScalarFunctionCatalogEntry(const char* name, function::function_set functionSet); | |||
There was a problem hiding this comment.
Ditto, we don't need this additional constructor
|
This is duplicated with #3079 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.