Remove the constraint on HashIndexBuilder's template parameter #3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3030 +/- ##
=======================================
Coverage 93.24% 93.24%
=======================================
Files 1133 1133
Lines 43117 43117
=======================================
+ Hits 40204 40205 +1
+ Misses 2913 2912 -1 ☔ View full report in Codecov by Sentry. |
ray6080
approved these changes
Mar 12, 2024
benjaminwinger
force-pushed
the
hash_index_template_types
branch
from
4fbaff3 to
21bda9c
Compare
The constraint seems to cause issues with MSVC 19.27 (#3022)
benjaminwinger
force-pushed
the
hash_index_template_types
branch
from
21bda9c to
b304389
Compare
benjaminwinger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constraint seems to cause issues with MSVC 19.27 (#3022), and I don't think it's necessary any more.
This fixes the compilation failure (see https://github.com/kuzudb/kuzu/actions/runs/8250693752), however there are now some tests failing on the VS2019 job, I'm not really sure why.
I've pulled a change to the typing (merging the two template parameters) out of #2997 as I didn't really want to modify the template parameters twice.