Scalar compile func #1679
Merged
Scalar compile func #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyfengHKU
commented
Jun 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1679 +/- ##
=======================================
Coverage 91.15% 91.16%
=======================================
Files 732 733 +1
Lines 26583 26623 +40
=======================================
+ Hits 24233 24270 +37
- Misses 2350 2353 +3
☔ View full report in Codecov by Sentry. |
acquamarin
approved these changes
Jun 14, 2023
| @@ -12,6 +12,9 @@ namespace function { | |||
|
|
|||
| struct VectorOperationDefinition; | |||
|
|
|||
| using scalar_compile_func = | |||
| std::function<void(FunctionBindData*, const std::vector<std::shared_ptr<common::ValueVector>>&, | |||
| std::shared_ptr<common::ValueVector>&)>; | |||
There was a problem hiding this comment.
i think we never use a reference to a shared_ptr, either change it to a raw ptr or remove reference
There was a problem hiding this comment.
This has to be a reference, because we are changing the shared_ptr inside compileFunc
andyfengHKU
force-pushed
the
scalar-compile-func
branch
from
92e1a6f to
896ff12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scalar_compile_func to remove special function evaluation that only happens at compile time.
Add
nodes(RECURSIVE_REL), reps(RECURSIVE_REL)