Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ResultSetDescriptor #1561

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

andyfengHKU
Copy link
Contributor

No description provided.

@andyfengHKU andyfengHKU requested a review from ray6080 May 22, 2023 21:51
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (ad3741e) 91.73% compared to head (6a03737) 91.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1561      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         698      698              
  Lines       25138    25128      -10     
==========================================
- Hits        23060    23049      -11     
- Misses       2078     2079       +1     
Impacted Files Coverage Δ
src/include/processor/mapper/plan_mapper.h 100.00% <ø> (ø)
src/include/processor/result/result_set.h 100.00% <ø> (ø)
src/processor/mapper/expression_mapper.cpp 100.00% <ø> (ø)
src/processor/mapper/map_distinct.cpp 100.00% <ø> (ø)
...c/include/processor/result/result_set_descriptor.h 100.00% <100.00%> (ø)
src/processor/mapper/map_accumulate.cpp 55.00% <100.00%> (ø)
src/processor/mapper/map_aggregate.cpp 96.49% <100.00%> (ø)
src/processor/mapper/map_cross_product.cpp 100.00% <100.00%> (ø)
src/processor/mapper/map_extend.cpp 94.78% <100.00%> (ø)
src/processor/mapper/map_hash_join.cpp 100.00% <100.00%> (ø)
... and 7 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/include/processor/result/result_set.h Outdated Show resolved Hide resolved
src/include/processor/result/result_set.h Outdated Show resolved Hide resolved
src/processor/result/result_set_descriptor.cpp Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU force-pushed the result-set-descriptor-rework branch from 977e464 to 6a03737 Compare May 23, 2023 01:27
@andyfengHKU andyfengHKU merged commit 91204de into master May 23, 2023
@andyfengHKU andyfengHKU deleted the result-set-descriptor-rework branch May 23, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants