Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially solves #951 to avoid flattening when multiple aggregate function presents.
The idea is that when evaluating an aggregate function, we input not only the aggregate vector but also other unFlat state to obtain a correct multiplicity.
E.g.
During aggregating, COUNT(a) will take vector "a" and also the state of vector "b" to figure the actual count.
At implementation level, we use
AggregateInput
(which wraps aggregate vector and unFlat data chunks) to replaceAggregateVector