Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factorization rewriter #1307

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Factorization rewriter #1307

merged 1 commit into from
Feb 22, 2023

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Feb 21, 2023 •
edited
Loading

This PR adds remove_factorization_rewriter and factorization_rewriter to decouple optimizer and planner

  • remove_factorization_rewriter
    • remove flatten operator from the logical plan
    • clear factorization schema
  • factorization_rewriter
    • insert flatten back to logical plan
    • recompute factorization schema

@andyfengHKU andyfengHKU requested a review from ray6080 February 21, 2023 20:16
ray6080
ray6080 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/include/optimizer/factorization_rewriter.h Show resolved Hide resolved
src/planner/operator/logical_extend.cpp Show resolved Hide resolved
src/include/planner/logical_plan/logical_operator/factorization_resolver.h Outdated Show resolved Hide resolved
@andyfengHKU andyfengHKU force-pushed the factorization-rewriter branch from 0096f2e to 6a191e6 Compare February 21, 2023 23:12
@andyfengHKU andyfengHKU merged commit 7534ee0 into master Feb 22, 2023
@andyfengHKU andyfengHKU deleted the factorization-rewriter branch February 22, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyfengHKU @ray6080