improve: image dialog load speed

kuusei · Jul 18, 2024 · f4a46b9 · f4a46b9
1 parent 3f4d9f3
commit f4a46b9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/web/src/components/Dialog/BaseDialog.tsx b/web/src/components/Dialog/BaseDialog.tsx
@@ -68,6 +68,7 @@ export function generateDialog<T extends DialogProps>(
   config: DialogConfig,
   DialogComponent: React.FC<T>,
   props?: Omit<T, "destroy">,
+  withoutCommonContext = true,
 ): DialogCallback {
   const tempDiv = document.createElement("div");
   const dialog = createRoot(tempDiv);
@@ -90,11 +91,17 @@ export function generateDialog<T extends DialogProps>(
   const Fragment = (
     <Provider store={store}>
       <CssVarsProvider theme={theme}>
-        <CommonContextProvider>
+        {withoutCommonContext ? (
           <BaseDialog destroy={cbs.destroy} clickSpaceDestroy={true} {...config}>
             <DialogComponent {...dialogProps} />
           </BaseDialog>
-        </CommonContextProvider>
+        ) : (
+          <CommonContextProvider>
+            <BaseDialog destroy={cbs.destroy} clickSpaceDestroy={true} {...config}>
+              <DialogComponent {...dialogProps} />
+            </BaseDialog>
+          </CommonContextProvider>
+        )}
       </CssVarsProvider>
     </Provider>
   );

diff --git a/web/src/components/PreviewImageDialog.tsx b/web/src/components/PreviewImageDialog.tsx
@@ -147,5 +147,6 @@ export default function showPreviewImageDialog(imgUrls: string[] | string, initi
       imgUrls: Array.isArray(imgUrls) ? imgUrls : [imgUrls],
       initialIndex: initialIndex || 0,
     },
+    true
   );
 }
-Original file line number
+Diff line change
@@ Expand Up @@
           imgUrls: Array.isArray(imgUrls) ? imgUrls : [imgUrls],
           initialIndex: initialIndex || 0,
         },
+        true
       );
     }