Skip to content

Commit

Permalink
feat: increase max upload size (#2552)
Browse files Browse the repository at this point in the history
## Description
Users trying to use `ImageBuildSpec` to build images inside their
packages have repositories greater than 100MB. Image building in
Kurtosis requires that the entire build context is within the package,
and thus gets uploaded into the APIContainer where the validation step
that builds images is done.

This PR increases the upload limit of the compression / upload library
to account for larger repositorie (2GB)

## Is this change user facing?
YES

## References (if applicable)
ethpandaops/optimism-package#72
  • Loading branch information
tedim52 authored Sep 18, 2024
1 parent 256d71a commit b6a0d91
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions path-compression/path_compresssion.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
)

const (
kurtosisDataTransferLimit = 100 * 1024 * 1024 // 100 MB
kurtosisDataTransferLimit = 2000 * 1024 * 1024 // ~2 GB
tempCompressionDirPattern = "upload-compression-cache-"
compressionExtension = ".tgz"
defaultTmpDir = ""
Expand Down Expand Up @@ -94,8 +94,8 @@ func CompressPathToFile(pathToCompress string, enforceMaxFileSizeLimit bool) (st

if enforceMaxFileSizeLimit && compressedFileSize >= kurtosisDataTransferLimit {
return "", 0, nil, stacktrace.NewError(
"The files you are trying to upload, which are now compressed, exceed or reach 100mb. " +
"Manipulation (i.e. uploads or downloads) of files larger than 100mb is currently disallowed in Kurtosis.")
"The files you are trying to upload, which are now compressed, exceed or reach 2 GB. " +
"Manipulation (i.e. uploads or downloads) of files larger than 2 GB is currently disallowed in Kurtosis.")
}

return compressedFilePath, compressedFileSize, compressedFileContentMd5.Sum(nil), nil
Expand Down

0 comments on commit b6a0d91

Please sign in to comment.