feat: E2E tests - iteration #1 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 13106060 | Triggered | Generic High Entropy Secret | 349dae1 | ci/obd-demo.yaml | View secret |
| 13334427 | Triggered | Username Password | 349dae1 | ci/docker-compose.yml | View secret |
| 13358409 | Triggered | Generic High Entropy Secret | 349dae1 | ci/obd-demo.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Deploying kardinal with
|
| Latest commit: |
2b24fbc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ee6f39b3.kardinal.pages.dev |
| Branch Preview URL: | https://laurent-e2e-tests-1.kardinal.pages.dev |
laurentluce
commented
Sep 7, 2024
laurentluce
commented
Sep 7, 2024
leoporoli
reviewed
Sep 9, 2024
leoporoli
reviewed
Sep 9, 2024
leoporoli
reviewed
Sep 9, 2024
leoporoli
approved these changes
Sep 9, 2024
laurentluce
pushed a commit
that referenced
this pull request
Sep 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.5](0.2.4...0.2.5) (2024-09-11) ### Features * calculator fixups and polish ([#200](#200)) ([a773cd9](a773cd9)) * cost calculator ([#191](#191)) ([45807a3](45807a3)) * E2E tests - iteration [#1](#1) ([#180](#180)) ([b65a916](b65a916)) * Support for tenant with no base cluster topology ([#199](#199)) ([9c91a82](9c91a82)) ### Bug Fixes * typo in calculator ([#201](#201)) ([0f0cf9b](0f0cf9b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CI job builds the CLI and Kardinal manager. The manager is deployed in Minikube with Istio installed. The boutique demo is deployed, the pods verified and the manager logs checked for errors. A dev flow is created and validated the same way before being deleted. The dev app access is not validated yet since I hit some issues with the port forwarding. I will continue to work on that with a new PR. Template operations are performed but with no validation yet.