Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IngressConfig to api #151

Merged
merged 5 commits into from
Aug 15, 2024
Merged

feat: add IngressConfig to api #151

merged 5 commits into from
Aug 15, 2024

Conversation

tedim52
Copy link
Contributor

@tedim52 tedim52 commented Aug 14, 2024

  • Add IngressConfig to our rest api
  • Parse Ingress objects off k8s manifest
  • Send them to server when calling deploy
    Now k8s manifest with Ingress objects such as this one won't fail:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: kontrol-ingress
  namespace: kardinal-kontrol
  labels:
    dev.kardinal.app-id: kardinal-kontrol
  annotations:
    nginx.ingress.kubernetes.io/rewrite-target: /$1
    kardinal.dev.service/ingress: "true"
spec:
  ingressClassName: nginx
  rules:
    - host: app.kardinal.dev
      http:
        paths:
          - path: /api/?(.*)
            pathType: ImplementationSpecific
            backend:
              service:
                name: kontrol-service-server
                port:
                  number: 8080
          - path: /?(.*)
            pathType: ImplementationSpecific
            backend:
              service:
                name: kontrol-frontend
                port:
                  number: 80
---

@tedim52 tedim52 changed the title Tedi/birdfooding feat: add IngressConfig to api Aug 14, 2024
@tedim52 tedim52 requested a review from laurentluce August 14, 2024 21:50
@tedim52 tedim52 merged commit 467b3e4 into main Aug 15, 2024
14 checks passed
h4ck3rk3y pushed a commit that referenced this pull request Aug 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.2.0](0.1.12...0.2.0)
(2024-08-16)


### ⚠ BREAKING CHANGES

* api definitions for templates
([#141](#141))

### Features

* add `IngressConfig` to api
([#151](#151))
([467b3e4](467b3e4))
* api definitions for templates
([#141](#141))
([c1c7687](c1c7687))
* website changes for launch
([#152](#152))
([43fd1af](43fd1af))


### Bug Fixes

* update privacy policy link
([#156](#156))
([cd88c1b](cd88c1b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants