fix: fix race condition with docs voting feature #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentluce
approved these changes
Sep 27, 2024
leoporoli
pushed a commit
that referenced
this pull request
Sep 27, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.1](0.3.0...0.3.1) (2024-09-27) ### Bug Fixes * fix race condition with docs voting feature ([#256](#256)) ([2d3f769](2d3f769)) * remove all Kardinal namespaces when cluster resources is empty during cleanup ([#255](#255)) ([43c4ac2](43c4ac2)) * telepresence http server check ([#251](#251)) ([c26f135](c26f135)) * try making some changes to change the asset hashes ([#254](#254)) ([668be13](668be13)) * Update the manager deploy kontrol service location command argument ([#252](#252)) ([08be35c](08be35c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a race condition that could occasionally cause the page to show an error if the rendering of the page completed before the request to the voting backend API completed. This fixes this race condition by providing stubbed / initial values in the voting context instead of
undefined.The error that was occasionally reproducible":
