Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

Commit

Permalink
fix: telepresence http server check (#251)
Browse files Browse the repository at this point in the history
It doesn't matter the status code in the server response, we just need
to know that a running server is responding on that port.
  • Loading branch information
leoporoli authored Sep 27, 2024
1 parent 2d3f769 commit c26f135
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions kardinal-cli/cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ var telepresenceInterceptCmd = &cobra.Command{

// Is the port open and HTTP
if err := isPortOpenAndHTTP(localPort); err != nil {
log.Fatalf("An error occurred checking port '%s': %s", localPort, err)
log.Fatalf("An error occurred checking HTTP server on port '%s': %s", localPort, err)
}

// is Traffic-manager installed
Expand Down Expand Up @@ -424,9 +424,6 @@ func isPortOpenAndHTTP(localPortStr string) error {
}
defer resp.Body.Close()

if resp.StatusCode != http.StatusOK {
return stacktrace.NewError("the HTTP server in 'httpServerAddr' did not return a successful response. Got '%d'", resp.StatusCode)
}
return nil
}

Expand Down

0 comments on commit c26f135

Please sign in to comment.