Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for tenant with no base cluster topology #199

Merged
merged 8 commits into from
Sep 11, 2024

Conversation

laurentluce
Copy link
Contributor

@laurentluce laurentluce commented Sep 9, 2024

This is the companion of kurtosis-tech/kardinal-kontrol#16

Copy link

gitguardian bot commented Sep 10, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13106060 Triggered Generic High Entropy Secret fb03af8 ci/obd-demo.yaml View secret
13334427 Triggered Username Password fb03af8 ci/docker-compose.yml View secret
13358409 Triggered Generic High Entropy Secret fb03af8 ci/obd-demo.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@laurentluce laurentluce merged commit 9c91a82 into main Sep 11, 2024
14 checks passed
laurentluce pushed a commit that referenced this pull request Sep 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.2.5](0.2.4...0.2.5)
(2024-09-11)


### Features

* calculator fixups and polish
([#200](#200))
([a773cd9](a773cd9))
* cost calculator
([#191](#191))
([45807a3](45807a3))
* E2E tests - iteration
[#1](#1)
([#180](#180))
([b65a916](b65a916))
* Support for tenant with no base cluster topology
([#199](#199))
([9c91a82](9c91a82))


### Bug Fixes

* typo in calculator
([#201](#201))
([0f0cf9b](0f0cf9b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants