Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add font options to the controller #48

Merged
merged 4 commits into from
Sep 1, 2021
Merged

Add font options to the controller #48

merged 4 commits into from
Sep 1, 2021

Conversation

stockiNail
Copy link
Contributor

This PR is adding the font options getting as default the font options on chart.options.

@kurkle
Copy link
Owner

kurkle commented Sep 1, 2021

I think toFont and lineHeight from the result could give better results

@stockiNail
Copy link
Contributor Author

I think toFont and lineHeight from the result could give better results

Done!

@kurkle kurkle added the enhancement New feature or request label Sep 1, 2021
@kurkle kurkle added this to the 0.8.0 milestone Sep 1, 2021
@stockiNail
Copy link
Contributor Author

I was thinking it could be better to use font.lineHeight here.

Ops... do you mean the following?

from:

 const textHeight = font.size;

to

 const textHeight = font.lineHeight;

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kurkle kurkle merged commit 3af9f55 into kurkle:master Sep 1, 2021
@stockiNail stockiNail deleted the fontOptions branch September 1, 2021 19:31
@stockiNail stockiNail mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stockiNail @kurkle