Don't get fooled by non-testing variables #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only calls to t.Run and t.Parallel should count. Without this, the linter might see a call to some other Run function and then complain that it contains no call to Parallel inside. This works by capturing the name of the testing.T parameter and only recognizing calls to Run and Parallel on variables with that name. False positives might occur if the parameter gets hidden. Fixed kunwardeep#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only calls to
t.Runandt.Parallelshould count. Without this, the linter might see a call to some otherRunfunction and then complain that it contains no call toParallelinside.This works by capturing the name of the
testing.Tparameter and only recognizing calls toRunandParallelon variables with that name. False positives might occur if the parameter gets hidden.Fixed #9