Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) make kumactl install control plane leverage the Helm Charts #989

Merged
merged 24 commits into from
Sep 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
871f633
chore(*) make kumactl install control-plane use Helm Charts
Aug 21, 2020
072d586
fix(helm) extra chars in cp-webhooks-and-secrets
Aug 25, 2020
847a231
fix(kumactl) tls arguments naming
Aug 25, 2020
7575517
fix(kumactl) namespace resource for Helm charts
Aug 25, 2020
e71236b
fix(kumactl) generate Values map without the first name
Aug 25, 2020
2eb554b
test(kumact) make one test pass
Aug 25, 2020
f2e867f
test(kumactl) make CNI test pass
Aug 25, 2020
4386948
fix(kumactl) order helm files when serializing
Aug 25, 2020
772a47a
fix(kumactl) install global cp test
Aug 25, 2020
68b852d
test(kumactl) fix remote install test
Aug 25, 2020
be6c744
test(kumactl) fix override install test
Aug 25, 2020
0b14db1
test(kumactl) fix completion tests
Aug 25, 2020
5a54ece
fix(kumactl) fix --use-node-port
Aug 26, 2020
04ee5f7
fix(kumactl) strip Helm specific labels
Aug 26, 2020
1a0fa19
Update deployments/charts/kuma/templates/cni-daemonset.yaml
Aug 27, 2020
e62c282
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Aug 30, 2020
81d833c
Merge remote-tracking branch 'origin/chore/kumactl_with_helm' into ch…
Aug 30, 2020
8e805ff
fix(kumactl) review remarks
Aug 30, 2020
85c6acf
chore(kumactl) re-generate from the templates
Aug 31, 2020
809df0c
Merge remote-tracking branch 'origin/master' into chore/kumactl_with_…
Sep 14, 2020
0dd0c9a
fix(*) after merge
Sep 14, 2020
4194e19
fix(*) review remarks
Sep 14, 2020
ed267b4
chore(*) get rid of the old templates
Sep 14, 2020
d1eac46
Merge remote-tracking branch 'origin/master' into chore/kumactl_with_…
Sep 15, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 30 additions & 12 deletions app/kumactl/cmd/completion/testdata/bash.golden
Original file line number Diff line number Diff line change
Expand Up @@ -1753,27 +1753,45 @@ _kumactl_install_control-plane()
local_nonpersistent_flags+=("--admission-server-tls-key=")
flags+=("--cni-enabled")
local_nonpersistent_flags+=("--cni-enabled")
flags+=("--cni-image=")
two_word_flags+=("--cni-image")
local_nonpersistent_flags+=("--cni-image=")
flags+=("--cni-registry=")
two_word_flags+=("--cni-registry")
local_nonpersistent_flags+=("--cni-registry=")
flags+=("--cni-repository=")
two_word_flags+=("--cni-repository")
local_nonpersistent_flags+=("--cni-repository=")
flags+=("--cni-version=")
two_word_flags+=("--cni-version")
local_nonpersistent_flags+=("--cni-version=")
flags+=("--control-plane-image=")
two_word_flags+=("--control-plane-image")
local_nonpersistent_flags+=("--control-plane-image=")
flags+=("--control-plane-registry=")
two_word_flags+=("--control-plane-registry")
local_nonpersistent_flags+=("--control-plane-registry=")
flags+=("--control-plane-repository=")
two_word_flags+=("--control-plane-repository")
local_nonpersistent_flags+=("--control-plane-repository=")
flags+=("--control-plane-service-name=")
two_word_flags+=("--control-plane-service-name")
local_nonpersistent_flags+=("--control-plane-service-name=")
flags+=("--control-plane-version=")
two_word_flags+=("--control-plane-version")
local_nonpersistent_flags+=("--control-plane-version=")
flags+=("--dataplane-image=")
two_word_flags+=("--dataplane-image")
local_nonpersistent_flags+=("--dataplane-image=")
flags+=("--dataplane-init-image=")
two_word_flags+=("--dataplane-init-image")
local_nonpersistent_flags+=("--dataplane-init-image=")
flags+=("--dataplane-init-registry=")
two_word_flags+=("--dataplane-init-registry")
local_nonpersistent_flags+=("--dataplane-init-registry=")
flags+=("--dataplane-init-repository=")
two_word_flags+=("--dataplane-init-repository")
local_nonpersistent_flags+=("--dataplane-init-repository=")
flags+=("--dataplane-init-version=")
two_word_flags+=("--dataplane-init-version")
local_nonpersistent_flags+=("--dataplane-init-version=")
flags+=("--dataplane-registry=")
two_word_flags+=("--dataplane-registry")
local_nonpersistent_flags+=("--dataplane-registry=")
flags+=("--dataplane-repository=")
two_word_flags+=("--dataplane-repository")
local_nonpersistent_flags+=("--dataplane-repository=")
flags+=("--dataplane-version=")
two_word_flags+=("--dataplane-version")
local_nonpersistent_flags+=("--dataplane-version=")
flags+=("--image-pull-policy=")
two_word_flags+=("--image-pull-policy")
local_nonpersistent_flags+=("--image-pull-policy=")
Expand Down
18 changes: 12 additions & 6 deletions app/kumactl/cmd/completion/testdata/zsh.golden
Original file line number Diff line number Diff line change
Expand Up @@ -743,13 +743,19 @@ function _kumactl_install_control-plane {
'--admission-server-tls-cert[TLS certificate for the admission web hooks implemented by the Kuma Control Plane]:' \
'--admission-server-tls-key[TLS key for the admission web hooks implemented by the Kuma Control Plane]:' \
'--cni-enabled[install Kuma with CNI instead of proxy init container]' \
'--cni-image[image of Kuma CNI component, if CNIEnabled equals true]:' \
'--cni-version[version of the CNIImage]:' \
'--control-plane-image[image of the Kuma Control Plane component]:' \
'--cni-registry[registry for the image of the Kuma CNI component]:' \
'--cni-repository[repository for the image of the Kuma CNI component]:' \
'--cni-version[version of the image of the Kuma CNI component]:' \
'--control-plane-registry[registry for the image of the Kuma Control Plane component]:' \
'--control-plane-repository[repository for the image of the Kuma Control Plane component]:' \
'--control-plane-service-name[Service name of the Kuma Control Plane]:' \
'--control-plane-version[version shared by all components of the Kuma Control Plane]:' \
'--dataplane-image[image of the Kuma Dataplane component]:' \
'--dataplane-init-image[init image of the Kuma Dataplane component]:' \
'--control-plane-version[version of the image of the Kuma Control Plane component]:' \
'--dataplane-init-registry[registry for the init image of the Kuma DataPlane component]:' \
'--dataplane-init-repository[repository for the init image of the Kuma DataPlane component]:' \
'--dataplane-init-version[version of the init image of the Kuma DataPlane component]:' \
'--dataplane-registry[registry for the image of the Kuma DataPlane component]:' \
'--dataplane-repository[repository for the image of the Kuma DataPlane component]:' \
'--dataplane-version[version of the image of the Kuma DataPlane component]:' \
'--image-pull-policy[image pull policy that applies to all components of the Kuma Control Plane]:' \
'--injector-failure-policy[failue policy of the mutating web hook implemented by the Kuma Injector component]:' \
'--kds-global-address[URL of Global Kuma CP (example: grpcs://192.168.0.1:5685)]:' \
Expand Down
Loading