fix(kuma-cp) add creation time

pkg/kds/store/sync.go

@@ -2,9 +2,9 @@ package store
 
 import (
 	"context"
-	"reflect"
-
 	"github.com/go-logr/logr"
+	"reflect"
+	"time"
 
 	"github.com/kumahq/kuma/pkg/core/resources/model"
 	"github.com/kumahq/kuma/pkg/core/resources/registry"
@@ -117,16 +117,21 @@ func (s *syncResourceStore) Sync(upstream model.ResourceList, fs ...SyncOptionFu
 	for _, r := range onCreate {
 		rk := model.MetaToResourceKey(r.GetMeta())
 		s.log.Info("creating a new resource from upstream", "resourceKey", rk)
+		creationTime := r.GetMeta().GetCreationTime()
 		// some Stores try to cast ResourceMeta to own Store type that's why we have to set meta to nil
 		r.SetMeta(nil)
-		if err := s.resourceStore.Create(ctx, r, store.CreateBy(rk)); err != nil {
+		if err := s.resourceStore.Create(ctx, r, store.CreateBy(rk), store.CreatedAt(creationTime)); err != nil {
 			return err
 		}
 	}
 
 	for _, r := range onUpdate {
 		s.log.Info("updating a resource", "resourceKey", model.MetaToResourceKey(r.GetMeta()))
-		if err := s.resourceStore.Update(ctx, r); err != nil {
+		now := time.Now()
+		// some stores manage ModificationTime time on they own (Kubernetes), in order to be consistent
+		// we set ModificationTime when we add to downstream store. This time is almost the same with ModificationTime
+		// from upstream store, because we update downstream only when resource have changed in upstream
+		if err := s.resourceStore.Update(ctx, r, store.ModifiedAt(now)); err != nil {
 			return err
 		}
 	}

pkg/kds/util/meta.go

@@ -16,10 +16,13 @@ type resourceMeta struct {
 	modificationTime *time.Time
 }
 
-func ResourceKeyToMeta(name, mesh string) model.ResourceMeta {
+func NewResourceMeta(name, mesh, version string, creationTime, modificationTime time.Time) model.ResourceMeta {
 	return &resourceMeta{
-		name: name,
-		mesh: mesh,
+		name:             name,
+		mesh:             mesh,
+		version:          version,
+		creationTime:     &creationTime,
+		modificationTime: &modificationTime,
 	}
 }
 

pkg/kds/util/resource.go

@@ -49,21 +49,17 @@ func ToEnvoyResources(rlist model.ResourceList) ([]envoy_types.Resource, error)
 func AddPrefixToNames(rs []model.Resource, prefix string) {
 	for _, r := range rs {
 		newName := fmt.Sprintf("%s.%s", prefix, r.GetMeta().GetName())
-		// method Sync takes into account only 'Name' and 'Mesh'. Another ResourceMeta's fields like
-		// 'Version', 'CreationTime' and 'ModificationTime' will be taken from downstream store.
-		// That's why we can set 'Name' like this
-		m := ResourceKeyToMeta(newName, r.GetMeta().GetMesh())
+		m := NewResourceMeta(newName, r.GetMeta().GetMesh(), r.GetMeta().GetVersion(),
+			r.GetMeta().GetCreationTime(), r.GetMeta().GetModificationTime())
 		r.SetMeta(m)
 	}
 }
 
 func AddSuffixToNames(rs []model.Resource, suffix string) {
 	for _, r := range rs {
 		newName := fmt.Sprintf("%s.%s", r.GetMeta().GetName(), suffix)
-		// method Sync takes into account only 'Name' and 'Mesh'. Another ResourceMeta's fields like
-		// 'Version', 'CreationTime' and 'ModificationTime' will be taken from downstream store.
-		// That's why we can set 'Name' like this
-		m := ResourceKeyToMeta(newName, r.GetMeta().GetMesh())
+		m := NewResourceMeta(newName, r.GetMeta().GetMesh(), r.GetMeta().GetVersion(),
+			r.GetMeta().GetCreationTime(), r.GetMeta().GetModificationTime())
 		r.SetMeta(m)
 	}
 }