Feat/vip outbound #834
Merged
Feat/vip outbound #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 16, 2020 17:36
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
feat/vip_outbound
branch
from
3bea89e to
78c7274
Compare
jakubdyszkiewicz
requested changes
Jun 17, 2020
pkg/xds/server/components.go
Outdated
| @@ -157,6 +154,14 @@ func DefaultDataplaneSyncTracker(rt core_runtime.Runtime, reconciler, ingressRec | |||
| return ingressReconciler.Reconcile(envoyCtx, &proxy) | |||
| } | |||
|
|
|||
| // Generate VIP outbounds only when in Kubernetes | |||
| if rt.Config().Environment == config_core.KubernetesEnvironment { | |||
There was a problem hiding this comment.
check dataplane.Spec.GetTransparentProxy() != nil instead
There was a problem hiding this comment.
Also when no Ingress :)
pkg/xds/topology/vip_outbounds.go
Outdated
| inService := inbound.GetTags()[mesh_proto.ServiceTag] | ||
|
|
||
| vip, err := resolver.ForwardLookup(inService) | ||
| if err != nil { |
There was a problem hiding this comment.
This logic should be gone after we change service.namespace.svc:port to service_namespace_svc_port right?
Can you add todo to remove it?
added 3 commits
June 17, 2020 17:00
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
feat/vip_outbound
branch
from
08b6aad to
76e4fd1
Compare
jakubdyszkiewicz
approved these changes
Jun 19, 2020
added 4 commits
June 20, 2020 10:24
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement the VIP Outbound generation.
Issues resolved
Fix #765
Documentation