chore(*) improve go mod handling in 1.14 #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a folder called `vendor` confises go 1.14. Rename it to `vendored` and this solves many potential issues. Including the need to pass `-mod=mod` in many cases. https://github.com/Kong/kuma/pull/718#issuecomment-625894360 Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
chore/fix_vendor_issues
branch
5 times, most recently
from
160866b to
77ee2bb
Compare
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
chore/fix_vendor_issues
branch
from
77ee2bb to
094f5f4
Compare
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
chore/fix_vendor_issues
branch
from
094f5f4 to
d9467d6
Compare
lobkovilya
reviewed
Jun 5, 2020
| @@ -29,7 +29,7 @@ build_info_ld_flags := $(foreach entry,$(build_info_fields), -X github.com/Kong/ | |||
| LD_FLAGS := -ldflags="-s -w $(build_info_ld_flags)" | |||
| GOOS := $(shell go env GOOS) | |||
| GOARCH := $(shell go env GOARCH) | |||
| GOFLAGS := -mod=mod | |||
| GOFLAGS := | |||
There was a problem hiding this comment.
Probably we don't need this variable anymore
There was a problem hiding this comment.
Well you never know. Let's keep it as a generic option that marks the places where it is used, so we can quickly add options if we need them in Go 1.15 for example ;)
jakubdyszkiewicz
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Having a folder called
vendorconfuses go 1.14. Rename it tovendoredand this solves many potential issues. Including the need to pass
-mod=modin many cases.
Reference: https://github.com/Kong/kuma/pull/718#issuecomment-625894360
We also bump OS/Xcode to 11.5.0 and Ubuntu 18.04 images in CircleCI.
A slight rearrangement of the
dev_ubuntutarget was needed in order to make tests actually pass and avoid the strange behavior when using Circle's own git client.