chore(releases): updating Alpine to 3.11 #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Use a more portable ip address resolving to work with the new Alpine. Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
chore/update-alpine
branch
from
c45a096 to
1fec421
Compare
nickolaev
force-pushed
the
chore/update-alpine
branch
7 times, most recently
from
fa8e6a5 to
9a02e83
Compare
added 2 commits
May 13, 2020 17:11
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
Signed-off-by: Nikolay Nikolaev <nikolay.nikolaev@konghq.com>
nickolaev
force-pushed
the
chore/update-alpine
branch
from
9a02e83 to
7050efb
Compare
lobkovilya
reviewed
May 13, 2020
| @@ -7,7 +7,7 @@ set -e | |||
| # | |||
|
|
|||
| function resolve_ip { | |||
| nslookup "${1}" 2>/dev/null | tail -1 | awk '{print $3}' | |||
| getent hosts ${DATAPLANE_HOSTNAME} 2>/dev/null | awk -e '{ print $1 }' | |||
There was a problem hiding this comment.
That's nice! Do you think we need to get local IP the same way here:
https://github.com/Kong/kuma/blob/master/pkg/plugins/runtime/k8s/webhooks/injector/injector.go#L169
and here: https://github.com/Kong/kuma/blob/master/pkg/plugins/runtime/k8s/webhooks/injector/injector.go#L185
There was a problem hiding this comment.
Not sure what you mean, but if you refer to resolving localhost that might be a thing. You should try it.
BTW all the credit for this specific solution should go to @jakubdyszkiewicz for finding it. I tried other tricks.
lobkovilya
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating alpine to version 3.11.
We also need to update the resolve_ip function when installing the example in docker-composer. Drop
nslookupand replace it with a simplergetnentapproach. This makes it more portable and stable across upgrades.Use the occasion to bump the Ubuntu image in the CI, so we ensure we run on the latest docker/docker-composer available in CirlceCI's VMs.