Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(deps): don't add filename to deps.lock hash #6032

Merged
merged 1 commit into from
Feb 14, 2023
Merged

ci(deps): don't add filename to deps.lock hash #6032

merged 1 commit into from
Feb 14, 2023

Conversation

lahabana
Copy link
Contributor

The filename was causing issues depending on where the sub folder is

Signed-off-by: Charly Molter charly.molter@konghq.com

Checklist prior to review

  • Link to docs PR or issue --
  • Link to UI issue or PR --
  • Is the issue worked on linked? --
  • The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) --
  • The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Unit Tests --
  • E2E Tests --
  • Manual Universal Tests --
  • Manual Kubernetes Tests --
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? --
  • Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

@lahabana
ci(deps): don't add filename to deps.lock hash
51cd9c7 
The filename was causing issues depending on where the sub folder is

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana requested review from a team, lobkovilya and lukidzi and removed request for a team February 14, 2023 16:28
@lahabana
Copy link
Contributor Author

@Mergifyio backport release-2.1 release-2.0 release-1.8 release-1.7 release-1.6 release-1.5

@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2023 •
edited
Loading

backport release-2.1 release-2.0 release-1.8 release-1.7 release-1.6 release-1.5

✅ Backports have been created

@lahabana lahabana added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Feb 14, 2023
@lahabana lahabana enabled auto-merge (squash) February 14, 2023 16:31
@lahabana lahabana merged commit 15cc640 into kumahq:master Feb 14, 2023
@mergify mergify bot mentioned this pull request Feb 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 14, 2023
@lahabana @mergify
ci(deps): don't add filename to deps.lock hash (#6032)
10caca3 
The filename was causing issues depending on where the sub folder is

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 15cc640)

# Conflicts:
#	mk/dependencies/deps.lock
@mergify mergify bot mentioned this pull request Feb 14, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 14, 2023
@lahabana @mergify
ci(deps): don't add filename to deps.lock hash (#6032)
66db507 
The filename was causing issues depending on where the sub folder is

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 15cc640)

# Conflicts:
#	mk/dependencies/deps.lock
#	tools/dev/install-dev-tools.sh
@mergify mergify bot mentioned this pull request Feb 14, 2023
Closed
mergify bot pushed a commit that referenced this pull request Feb 14, 2023
@lahabana @mergify
ci(deps): don't add filename to deps.lock hash (#6032)
67b8813 
The filename was causing issues depending on where the sub folder is

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 15cc640)

# Conflicts:
#	mk/dependencies/deps.lock
#	tools/dev/install-dev-tools.sh
mergify bot pushed a commit that referenced this pull request Feb 14, 2023
@lahabana @mergify
ci(deps): don't add filename to deps.lock hash (#6032)
e3ea71c 
The filename was causing issues depending on where the sub folder is

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 15cc640)

# Conflicts:
#	mk/dependencies/deps.lock
#	tools/dev/install-dev-tools.sh
@mergify mergify bot mentioned this pull request Feb 14, 2023
Closed
mergify bot pushed a commit that referenced this pull request Feb 14, 2023
@lahabana @mergify
ci(deps): don't add filename to deps.lock hash (#6032)
466dfac 
The filename was causing issues depending on where the sub folder is

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 15cc640)

# Conflicts:
#	mk/dependencies/deps.lock
#	tools/dev/install-dev-tools.sh
This was referenced Feb 14, 2023
Closed
Closed
mergify bot pushed a commit that referenced this pull request Feb 14, 2023
@lahabana @mergify
ci(deps): don't add filename to deps.lock hash (#6032)
f4ec985 
The filename was causing issues depending on where the sub folder is

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 15cc640)

# Conflicts:
#	mk/dependencies/deps.lock
#	tools/dev/install-dev-tools.sh
lahabana added a commit that referenced this pull request Feb 14, 2023
@mergify @lahabana
ci(deps): don't add filename to deps.lock hash (backport #6032) (#6033)
1fed8bb 
* ci(deps): don't add filename to deps.lock hash (#6032)

The filename was causing issues depending on where the sub folder is

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 15cc640)

# Conflicts:
#	mk/dependencies/deps.lock

* fix lock

Signed-off-by: Charly Molter <charly.molter@konghq.com>

---------

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Co-authored-by: Charly Molter <charly.molter@konghq.com>
lahabana added a commit that referenced this pull request Feb 14, 2023
@mergify @lahabana
ci(deps): don't add filename to deps.lock hash (backport #6032) (#6034)
f2d591e 
* ci(deps): don't add filename to deps.lock hash (#6032)

The filename was causing issues depending on where the sub folder is

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 15cc640)

# Conflicts:
#	mk/dependencies/deps.lock
#	tools/dev/install-dev-tools.sh

* update lock

Signed-off-by: Charly Molter <charly.molter@konghq.com>

* add call to file

Signed-off-by: Charly Molter <charly.molter@konghq.com>

---------

Signed-off-by: Charly Molter <charly.molter@konghq.com>
Co-authored-by: Charly Molter <charly.molter@konghq.com>
@shaneutt shaneutt mentioned this pull request Feb 14, 2023
Merged
This was referenced Feb 15, 2023
Closed
Closed
Closed
@lahabana lahabana deleted the betterLock branch May 2, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

@lobkovilya lobkovilya Awaiting requested review from lobkovilya

@lukidzi lukidzi Awaiting requested review from lukidzi

Assignees
No one assigned
Labels
ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lahabana @michaelbeaumont @jakubdyszkiewicz