Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix version sh pipe exit #5816

Merged
merged 1 commit into from
Jan 24, 2023
Merged

chore: fix version sh pipe exit #5816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tools/releases/version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#!/usr/bin/env bash

set -o errexit
set -o pipefail

function envoy_version() {
set -o errexit
set -o pipefail
set -o nounset
# Returns Envoy version by ENVOY_TAG:
# - if ENVOY_TAG is a real git tag like 'v1.20.0' then the version is equal to '1.20.0' (without the first letter 'v').
# - if ENVOY_TAG is a commit hash then the version will look like '1.20.1-dev-b16d390f'
Expand All @@ -21,6 +21,9 @@ function envoy_version() {
else
echo "${ENVOY_VERSION}-${ENVOY_TAG:0:8}"
fi
set +o errexit
set +o pipefail
set +o nounset
}

function version_info() {
Expand Down