feat(build): idempotent builds

[slonka]

Signed-off-by: slonka slonka@users.noreply.github.com

Closes #5270

EDIT:

To be more precise what I don't like about this PR:

• build date - is it even needed? we seem to only pass it around and there is no computation based on it
  • we could remove it altogether, but that is passed around in KDS so it seems a bit too much for this PR
  • use static date (this is what is done now) - if someone ever needs to figure out the version by this date it would be impossible
  • use only Y/M/D without hours / minutes - less wrong than the above, not sure it matters
• changing binary creation / modification time
  • there seems to be no workaround for this, docker just uses it for the cache so 😭, but is this acceptable

I had a chat with Bart and we decided that we can always iterate on this.

Old notes:

Not sure what happened (maybe docker update or something on my mac) but the image build times from the issue are a lot faster when I tested them today. Anyway with this PR I managed to cut down make images time from ~35 seconds to ~20 seconds on my machine and even a bigger improvement ~115 seconds to ~85 seconds when running an example e2e test ( gtime -q -f "%e" make -j test/e2e/debug-fast K3D=true E2E_PKG_LIST=./test/e2e/deploy/... ).

Overall I'm not super happy with this change, there are a couple of hacks here, with your help I hope we can make it better.

Checklist prior to review

• Link to docs PR or issue -- build improvement
• Link to UI issue or PR -- not a UI issue
• Is the issue worked on linked? -- yes
• The PR does not hardcode values that might break projects that depend on kuma (e.g. "kumahq" as a image registry) -- yes
• The PR will work for both Linux and Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
• Unit Tests --
• E2E Tests --
• Manual Universal Tests --
• Manual Kubernetes Tests --
• Do you need to update UPGRADE.md? --
• Does it need to be backported according to the backporting policy? --
• Do you need to explicitly set a > Changelog: entry here or add a ci/ label to run fewer/more tests?

Changelog: feat(build): idempotent build

[bartsmykla]

I have few suggestions

[slonka]

Note to self: version.sh is called from other places so other call sites need to be adjusted.

[bartsmykla]

I've run come commands on my mbp (intel), here are the results:

# master

gtime -q -f "%e" make images
# 192.04
# 70.12

gtime -q -f "%e" make -j test/e2e/debug-fast K3D=true E2E_PKG_LIST=./test/e2e/ownership/...
# 255.82
# 261.80

# feat/make-local-builds-idempotent

gtime -q -f "%e" make images
# 131.41
# 35.25

gtime -q -f "%e" make -j test/e2e/debug-fast K3D=true E2E_PKG_LIST=./test/e2e/ownership/...
# 268.30
# 207.96

[slonka]

☝️ one note to this, running make images "seeded" cache for the subsequent build. Nevertheless we see 50% improvement in make images and it's reflected in e2e test.

[bartsmykla]

few nits, but lgtm overall

[slonka]

I had to remove the "touch -mt" hack to cache the context sent do docker because it was caching too much.