kuma-cp: add a custom version of SnapshotCache that supports arbitrary xDS resources #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
force-pushed
the
feature/custom-snapshot-cache
branch
2 times, most recently
from
55a3175 to
cfc2b2f
Compare
jakubdyszkiewicz
approved these changes
Jan 8, 2020
| envoy_log "github.com/envoyproxy/go-control-plane/pkg/log" | ||
| ) | ||
|
|
||
| // This is a slightly modified version of SnapshotCache from github.com/envoyproxy/go-control-plane |
There was a problem hiding this comment.
Can we contribute to go-control-plane?
I've seen pattern before (copying SnapshotCache from x-control-plane) in home grown control plane, because we had to fix something and didn't have time to wait. Then you have to maintain this file - remember to look at changes to this file with every upgrade of go-control-plane.
We can go with it for now, but can we at least make an issue to avoid this?
yskopets
force-pushed
the
refactoring/reuse-control-plane-logger
branch
from
7d23199 to
b36d4e4
Compare
yskopets
changed the base branch from
refactoring/reuse-control-plane-logger
to
master
yskopets
force-pushed
the
feature/custom-snapshot-cache
branch
from
cfc2b2f to
3cc4bb8
Compare
|
@jakubdyszkiewicz Could you please do a follow-up review after mutable |
yskopets
force-pushed
the
feature/custom-snapshot-cache
branch
from
d6c3ec6 to
4fff2db
Compare
jakubdyszkiewicz
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SnapshotCachethat supports arbitrary xDS resources