ProxyTemplate validation #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/xds/template/raw.go
Outdated
| @@ -0,0 +1,38 @@ | |||
| package template | |||
There was a problem hiding this comment.
not sure about placement of this file. I could not put it into envoy package because of the cyclic import.
There was a problem hiding this comment.
Same comment as above, let's avoid dependency pkg/core/resources/apis/mesh => pkg/xds/template.
Maybe pkg/util/envoy ?
jakubdyszkiewicz
force-pushed
the
feature/proxytemplate-validation
branch
from
33f585f to
aa58e78
Compare
yskopets
suggested changes
Nov 14, 2019
pkg/xds/template/raw.go
Outdated
| @@ -0,0 +1,38 @@ | |||
| package template | |||
There was a problem hiding this comment.
Same comment as above, let's avoid dependency pkg/core/resources/apis/mesh => pkg/xds/template.
Maybe pkg/util/envoy ?
jakubdyszkiewicz
force-pushed
the
feature/proxytemplate-validation
branch
from
8e136aa to
a88dd54
Compare
yskopets
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Validation of ProxyTemplate resource.
Also added validation of the Envoy resource itself.
Should we require either imports or resources to be present or empty ProxyTemplate with selectors is fine too?