Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to the latest version of go-control-plane and use golang/protobuf instead of gogo/protobuf #419

Merged
merged 2 commits into from
Nov 11, 2019
Merged

chore: migrate to the latest version of go-control-plane and use golang/protobuf instead of gogo/protobuf #419

merged 2 commits into from
Nov 11, 2019

Conversation

yskopets
Copy link
Contributor

@yskopets yskopets commented Nov 9, 2019 •
edited
Loading

Summary

  • to be able to use our L4 subset load balancing feature contributed to Envoy, we need to upgrade dependency on go-control-plane
  • unfortunately, go-control-plane has changed in a backwards-incompatible way in v0.9.0 (usage of gogo/protobuf was replaced with golang/protobuf)
  • that's why we need to refactor our own code
  • additionally, for consistency with go-control-plane, we are also moving from gogo/protobuf to golang/protobuf

Watch out!

  • by dropping gogo/protobuf we loose a few of its features we were using
    • it's no longer possible to use (gogoproto.nullable) = false option to force code generator to generate non-nillable fields (we used this in DataplaneInsight and DataplaneOverview)
    • so, watch out for nils

@yskopets
chore: migrate to the latest version of go-control-plane and use `g…
8395582 
…olang/protobuf` instead of `gogo/protobuf`
@yskopets yskopets requested review from a team and jakubdyszkiewicz November 9, 2019 11:52
@yskopets yskopets added this to the 0.3.0 milestone Nov 9, 2019
jakubdyszkiewicz
jakubdyszkiewicz approved these changes Nov 11, 2019
View reviewed changes
@yskopets yskopets merged commit e5d98f8 into master Nov 11, 2019
@yskopets yskopets deleted the feature/migrate-to-the-latest-go-control-plane branch December 19, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubdyszkiewicz jakubdyszkiewicz Awaiting requested review from jakubdyszkiewicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yskopets @jakubdyszkiewicz