feat(kuma-cp) validate resources on kubernetes #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yskopets
reviewed
Nov 4, 2019
There was a problem hiding this comment.
The output of kubectl apply is not user-friendly.
E.g., I use the following test resource
echo "apiVersion: kuma.io/v1alpha1
kind: Dataplane
mesh: default
metadata:
name: example
namespace: kuma-example
spec:
networking:
inbound:
- interface: 127.0.0.1:11011:abc
tags:
version: v2
env: production
outbound:
- interface: :cd
service2: database" | kubectl apply -f -and I get back
Error from server (validation error: Inbound[0]: Interface: invalid format: expected format is <DATAPLANE_IP>:<DATAPLANE_PORT>:<WORKLOAD_PORT> ex. 192.168.0.100:9090:8080; "service" tag has to exist and be non empty; Outbound[0]: Interface: invalid format: expected ^(?P<dataplane_ip>(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)|):(?P<dataplane_port>[0-9]{1,5})$, got ":cd"; Service cannot be empty): error when creating "STDIN": admission webhook "validator.kuma-admission.kuma.io" denied the request: validation error: Inbound[0]: Interface: invalid format: expected format is <DATAPLANE_IP>:<DATAPLANE_PORT>:<WORKLOAD_PORT> ex. 192.168.0.100:9090:8080; "service" tag has to exist and be non empty; Outbound[0]: Interface: invalid format: expected ^(?P<dataplane_ip>(?:(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)|):(?P<dataplane_port>[0-9]{1,5})$, got ":cd"; Service cannot be empty
jakubdyszkiewicz
force-pushed
the
feature/validation-kubernetes
branch
from
91b8e37 to
3052703
Compare
|
Sorry the force push |
yskopets
approved these changes
Nov 12, 2019
|
|
||
| coreRes, err := h.coreRegistry.NewObject(resType) | ||
| if err != nil { | ||
| return admission.Errored(http.StatusInternalServerError, err) |
There was a problem hiding this comment.
Let's do return admission.Errored(http.StatusBadRequest, err)
| } | ||
| obj, err := h.k8sRegistry.NewObject(coreRes.GetSpec()) | ||
| if err != nil { | ||
| return admission.Errored(http.StatusInternalServerError, err) |
There was a problem hiding this comment.
Let's do return admission.Errored(http.StatusBadRequest, err)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Validation resources on K8S. We register one ValidatingWebhookConfiguration for all resources.