fix(kuma-cp) Switch leader election to leader-for-life #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 27, 2021 10:31
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
jpeach
reviewed
Nov 10, 2021
added 2 commits
November 10, 2021 09:40
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
…o fix/leader-election-loss
jakubdyszkiewicz
approved these changes
Nov 10, 2021
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2021
* fix(kuma-cp) Switch leader election to leader-for-life Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * tests(kuma-cp) Make check Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * fix(kuma-cp) Add pod name to install env for leader election Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * fix(kuma-cp) Force acquire deprecated locks Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> * fix(kuma-cp) PR comments - minor style changes Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> (cherry picked from commit f5b2b27) # Conflicts: # go.mod # go.sum # pkg/plugins/bootstrap/k8s/plugin.go
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Parkanzky paul.parkanzky@konghq.com
Summary
Work in progress on switching to leader election as leader-for-life. Will upgrade to actual PR when sufficiently tested.
Note, need this extra config on kuma-cp container ENV
I've added this to kumactl install, however this breaks compatibility between newer versions of kuma-cp and previous kumactl.
Full changelog
Documentation
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.