chore(ci) split e2e deployment options #2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's hard to understand which deployment options only apply to the Kuma control plane, and which apply to arbitrarry applications. Split the options in two, and fix up all the relevant option types so that we have strong typing all the way down, and it's obvious which options apply to which tasks. Signed-off-by: James Peach <james.peach@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2950 +/- ##
=======================================
Coverage 52.31% 52.31%
=======================================
Files 909 909
Lines 52399 52431 +32
=======================================
+ Hits 27413 27430 +17
- Misses 22792 22806 +14
- Partials 2194 2195 +1
Continue to review full report at Codecov.
|
michaelbeaumont
approved these changes
Oct 13, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2021
It's hard to understand which deployment options only apply to the Kuma control plane, and which apply to arbitrarry applications. Split the options in two, and fix up all the relevant option types so that we have strong typing all the way down, and it's obvious which options apply to which tasks. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 96217b5) # Conflicts: # test/e2e/auth/auth_universal.go
jpeach
added a commit
that referenced
this pull request
Oct 18, 2021
It's hard to understand which deployment options only apply to the Kuma control plane, and which apply to arbitrarry applications. Split the options in two, and fix up all the relevant option types so that we have strong typing all the way down, and it's obvious which options apply to which tasks. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 96217b5)
jpeach
added a commit
that referenced
this pull request
Oct 18, 2021
It's hard to understand which deployment options only apply to the Kuma control plane, and which apply to arbitrarry applications. Split the options in two, and fix up all the relevant option types so that we have strong typing all the way down, and it's obvious which options apply to which tasks. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 96217b5) Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's hard to understand which deployment options only apply to the Kuma
control plane, and which apply to arbitrarry applications. Split the
options in two, and fix up all the relevant option types so that we have
strong typing all the way down, and it's obvious which options apply to
which tasks.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.