Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci) ensure helm repo is present for compatibility tests (backport #2861) #2868

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 3, 2021

This is an automatic backport of pull request #2861 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

The e2e compatibility tests use helm to install an older version of
Kuma using helm. That means that we need to ensure that the Kuma helm
repository is added and updated, even if there are side-effects on the
test execution environment.

This fixes #2853.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit fb7b5a0)
@mergify mergify bot requested a review from a team as a code owner October 3, 2021 23:01
@codecov-commenter
Copy link

Codecov Report

Merging #2868 (eb0be84) into release-1.3 (3bdcab3) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.3    #2868      +/-   ##
===============================================
+ Coverage        52.43%   52.44%   +0.01%     
===============================================
  Files              888      888              
  Lines            51746    51755       +9     
===============================================
+ Hits             27132    27145      +13     
+ Misses           22460    22455       -5     
- Partials          2154     2155       +1     
Impacted Files Coverage Δ
...atibility/cp_compatibility_kubernetes_multizone.go 0.00% <0.00%> (ø)
pkg/core/resources/manager/cache.go 81.81% <0.00%> (ø)
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bdcab3...eb0be84. Read the comment docs.

@jpeach jpeach merged commit 377dee3 into release-1.3 Oct 4, 2021
@jpeach jpeach deleted the mergify/bp/release-1.3/pr-2861 branch October 4, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants