fix(kumactl) Only warn about version compatibility where it makes sense (backport #2828) #2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## release-1.3 #2833 +/- ##
===============================================
+ Coverage 52.12% 52.14% +0.01%
===============================================
Files 881 882 +1
Lines 51232 51263 +31
===============================================
+ Hits 26706 26731 +25
+ Misses 22407 22393 -14
- Partials 2119 2139 +20
Continue to review full report at Codecov.
|
…se (#2828) * fix(kumactl) Add method to check server version compatibility Also remove logging with the k8s logger Signed-off-by: Michael Beaumont <mjboamail@gmail.com> * fix(kumactl) Only warn about version compatibility where it makes sense Warn for: apply, delete, generate, get, inspect Don't warn for: completion, config, install, uninstall, version Signed-off-by: Michael Beaumont <mjboamail@gmail.com> (cherry picked from commit 4bf896a) Signed-off-by: Mike <2266568+michaelbeaumont@users.noreply.github.com>
michaelbeaumont
force-pushed
the
mergify/bp/release-1.3/pr-2828
branch
from
37b0992 to
dc061bc
Compare
michaelbeaumont
approved these changes
Sep 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #2828 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/