Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests) fix test expectations due to package-level variable #2830

Closed

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Sep 23, 2021

Summary

In these two tests we can't contact the API server and so the warning is printed by the compiled kumactl. This line

https://github.com/michaelbeaumont/kuma/blob/1333e7c965a15bed2527cf69977931021add4c35/app/kumactl/cmd/root.go#L79

is being hit and thus we aren't initializing kumaBuildVersion, but kumaBuildVersion is nevertheless != nil. With FIt we can see that whether we run the other tests determines if these pass or fail.

Full changelog

  • fix(tests) fix test expectations due to global variable

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner September 23, 2021 15:29
Signed-off-by: Michael Beaumont <mjboamail@gmail.com>
@jakubdyszkiewicz
Copy link
Contributor

I think we should get rid of this check in config cmd. So commands like kumactl config add do not throw warnings. If you are messing around with config it is expected that you don't have a connection to the control plane yet

@michaelbeaumont
Copy link
Contributor Author

@jakubdyszkiewicz makes sense actually, closing for #2828

@michaelbeaumont michaelbeaumont deleted the fix/tests_warning branch September 24, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants