fix(tests) fix test expectations due to package-level variable #2830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In these two tests we can't contact the API server and so the warning is printed by the compiled
kumactl
. This linehttps://github.com/michaelbeaumont/kuma/blob/1333e7c965a15bed2527cf69977931021add4c35/app/kumactl/cmd/root.go#L79
is being hit and thus we aren't initializing
kumaBuildVersion
, butkumaBuildVersion
is nevertheless!= nil
. WithFIt
we can see that whether we run the other tests determines if these pass or fail.Full changelog
Testing
Manual testing on UniversalManual testing on KubernetesBackwards compatibility
Addbackport-to-stable
label if the code is backwards compatible. Otherwise, list breaking changes.