Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: docker automation #265

Merged
merged 4 commits into from
Sep 17, 2019
Merged

ci: docker automation #265

merged 4 commits into from
Sep 17, 2019

Conversation

gszr
Copy link
Contributor

@gszr gszr commented Sep 16, 2019

Summary

  • Add script to automate Docker images build and release
  • Integrate Docker automation into Circle CI

dhruv
dhruv suggested changes Sep 16, 2019
View reviewed changes
@gszr gszr force-pushed the ci/docker-automation branch 7 times, most recently from 6e50681 to 4d92c89 Compare September 16, 2019 21:53
@gszr gszr force-pushed the ci/docker-automation branch from 4d92c89 to 11fb466 Compare September 16, 2019 22:19
@gszr gszr marked this pull request as ready for review September 16, 2019 22:19
@dhruv dhruv merged commit 8206bd5 into master Sep 17, 2019
yskopets
yskopets reviewed Sep 18, 2019
View reviewed changes
Copy link
Contributor

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, release job does everything at once (all components, all steps).

What will happen if one of the steps fails (e.g. deploy of *.tar.gz to bintray.io) ? Will the second run of release work ?

tools/releases/dockerfiles/Dockerfile.kuma-cp
@@ -0,0 +1,12 @@
FROM alpine:3.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker image should run under a non-root account, e.g. nobody (65534:65534) on alpine

tools/releases/dockerfiles/Dockerfile.kuma-injector
@@ -0,0 +1,9 @@
FROM alpine:3.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker image should run under a non-root account, e.g. nobody (65534:65534) on alpine

tools/releases/dockerfiles/Dockerfile.kuma-tcp-echo
@@ -0,0 +1,9 @@
FROM alpine:3.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker image should run under a non-root account, e.g. nobody (65534:65534) on alpine

tools/releases/dockerfiles/Dockerfile.kuma-dp
@@ -0,0 +1,10 @@
# using Envoy's base to inherit the Envoy binary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker image should run under a non-root account, e.g. nobody (65534:65534) on alpine

tools/releases/docker.sh
docker_login

for component in "${KUMA_COMPONENTS[@]}"; do
msg "Pushing kuma-cp..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the message to Pushing $component ... ?

@yskopets yskopets deleted the ci/docker-automation branch December 19, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yskopets yskopets yskopets left review comments

@dhruv dhruv dhruv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gszr @dhruv @yskopets