Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update build script, integrate with circleci #250

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Conversation

gszr
Copy link
Contributor

@gszr gszr commented Sep 11, 2019

Summary

  • Update build script, automating builds for all distributions and architectures
  • Integrate build script with CircleCI

Releases are automatically built and pushed to Bintray whenever a tag is pushed.

@gszr gszr force-pushed the ci/build-script branch 5 times, most recently from 247cdff to 50501fe Compare September 12, 2019 01:11
@gszr gszr marked this pull request as ready for review September 12, 2019 01:12
@gszr gszr force-pushed the ci/build-script branch 2 times, most recently from e9620a3 to 65d95ea Compare September 12, 2019 02:24
@gszr gszr added the ci label Sep 12, 2019
Copy link
Contributor

@yskopets yskopets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gszr .
Great work! Thanks a lot.

I've left a few comments on source files.
Additionally, I'm also wondering:

  1. would it be possible to setup a test repo on bintray so that we could test these scripts before merging into master ?
  2. I don't see handling of Docker images. will it be a separate PR ?

@gszr
Copy link
Contributor Author

gszr commented Sep 12, 2019

Will do one more test release on top of the "wip" commit (changing the Bintray repository to kuma-tests) - it'll be pushed to https://bintray.com/kong/kuma-tests.

Edit: test was completed, commit reverted.

@gszr gszr requested a review from yskopets September 12, 2019 21:18
dhruv
dhruv previously approved these changes Sep 12, 2019
@dhruv
Copy link

dhruv commented Sep 12, 2019

Actually, we need the envoy binaries in the distributions.

@dhruv dhruv dismissed their stale review September 12, 2019 22:24

We need envoy binaries

@gszr gszr force-pushed the ci/build-script branch 5 times, most recently from 3eaa820 to 324f7d6 Compare September 13, 2019 00:25
@gszr gszr requested a review from dhruv September 13, 2019 00:26
@gszr
Copy link
Contributor Author

gszr commented Sep 13, 2019

Additionally, I'm also wondering:
1. would it be possible to setup a test repo on bintray so that we could test these scripts before merging into master ?

I've been testing on https://bintray.com/kong/kuma-tests.

2. I don't see handling of Docker images. will it be a separate PR ?

Yes, it will be done in a separate PR.

@gszr gszr force-pushed the ci/build-script branch 2 times, most recently from 6c245fa to 2dc34be Compare September 13, 2019 18:07
@gszr gszr requested a review from yskopets September 13, 2019 18:12
@yskopets
Copy link
Contributor

@gszr awesome shell script, by the way.

Thanks a lot!

@gszr gszr merged commit 9025a3c into master Sep 13, 2019
@gszr gszr deleted the ci/build-script branch September 13, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants