fix(kumactl) Check version after loading config. #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
parkanzky
force-pushed
the
fix/check-version-after-loading-cfg
branch
from
26c781f to
2e166f9
Compare
* Properly early-return error to calling function * Send warnings to stderr Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
parkanzky
force-pushed
the
fix/check-version-after-loading-cfg
branch
from
22ed49a to
a5c8ced
Compare
jakubdyszkiewicz
approved these changes
Apr 26, 2021
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The version comparison in kumactl was not working - it would attempt to connect to kuma-cp to retrieve version prior to loading config and that retrieval would silently fail. This fix moves the API call to happen after config loads.
Also changed the error message to conform to what is specified in the ticket.
Full changelog