Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store creation date of every entity #661

Closed
subnetmarco opened this issue Apr 4, 2020 · 3 comments · Fixed by #677
Closed

Store creation date of every entity #661

subnetmarco opened this issue Apr 4, 2020 · 3 comments · Fixed by #677

Comments

@subnetmarco
Copy link
Contributor

Store the UTC creation date timestamp for every entity that is being created.
@subnetmarco subnetmarco mentioned this issue Apr 4, 2020
Closed
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 4, 2020
@tharun208
fix(kumactl) storing the created time and modified time for resources
5740d7b 
* Added creationTime and modifiedTime to resource creation at kumactl
Fix kumahq#661
@tharun208 tharun208 mentioned this issue Apr 4, 2020
Closed
@tharun208
Copy link
Contributor

Created a PR for this @subnetmarco 😀

@jakubdyszkiewicz
Copy link
Contributor

We store this already, but it isn't exposed in the API (we use it to sort conflicts on matching policies)
We store creation time and modification time, but keep in mind that creation time is equal to modification time on K8S.

Do you have any format in mind on how to expose it? @subnetmarco
One of the way could be this

type: Dataplane
mesh: default
name: redis-1
creationTime: 2020-04-05T21:18:35Z
modificationTime: 2020-04-05T21:18:35Z
networking:
  address: 192.168.0.1
  inbound:
  - port: 9000
    servicePort: 6379
    tags:
      service: redis

@subnetmarco
Copy link
Contributor Author

Yes, that would work @jakubdyszkiewicz

tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime in kuma
665fd13 
* added creationTime and modificationTime in resource
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime in kuma
5706587 
* updated api server tests
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma get dataplanes
dd2e5b1 
* updated tests
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma get fault in…
cc845a1 
…jections

* updated tests
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma get health c…
af336c9 
…hecks

* updated tests
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma get meshes
fbc8468 
* updated tests
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma get proxy Te…
7f55289 
…mplates

* updated tests
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma get traffic …
a3198ed 
…logs

* updated tests
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma get traffic …
e8a7445 
…permissions

* updated tests
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma get traffic …
6fe53f3 
…routes

* updated tests
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma get traffic …
d8dc012 
…traces

* updated tests
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma inspect data…
fd0ba3c 
…planes

* updated tests
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma
e104eb0 
* fixed tests for printer
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma
6acce39 
* fixed remote store create and update function and updated tests
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
feature exposed creationTime & modificationTime for kuma
0d80de7 
* fixed apply tests
Feature kumahq#661
@tharun208 tharun208 mentioned this issue Apr 14, 2020
Merged
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
* update api-server resource tests with proper dateTime
080c42e 
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
* removed unwanted omitempty tag for creationTime and modificationTime
1527053 
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 14, 2020
@tharun208
* updated apply dry-run to return noop date-time
99117f7 
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 15, 2020
@tharun208
Merge remote-tracking branch 'origin/master' into feat/kumahq#661
84162e1
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 15, 2020
@tharun208
Merge remote-tracking branch 'origin/master' into feat/kumahq#661
522f1e8
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 15, 2020
@tharun208
* updated get single resource test data
f57aa4f 
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 15, 2020
@tharun208
* added createdAt and modifiedAt params to upsert function in apply
2701594 
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 15, 2020
@tharun208
* added createdAt and modifiedAt params to upsert function in apply
e5ed83b 
Feature kumahq#661
tharun208 added a commit to tharun208/kuma that referenced this issue Apr 21, 2020
@tharun208
Merge remote-tracking branch 'origin/master' into feat/kumahq#661
a5b7ad4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@subnetmarco @jakubdyszkiewicz @tharun208