Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kumactl delete command #279

Closed
yskopets opened this issue Sep 23, 2019 · 5 comments · Fixed by #343
Closed

Add kumactl delete command #279

yskopets opened this issue Sep 23, 2019 · 5 comments · Fixed by #343
Assignees
@pradeepmurugesan
Labels
good first issue Good for newcomers
Milestone
0.3.0

Comments

@yskopets
Copy link
Contributor

yskopets commented Sep 23, 2019 •
edited
Loading

Summary

  • Add kumactl delete command
    • only support removal of individual resources, namely 
      DELETE /meshes/<mesh name>
DELETE /meshes/<mesh name>/<policy type>/<policy name>
    • only support removal in universal mode (requires no extra development since Kuma API runs in read-only mode on k8s)
@pradeepmurugesan
Copy link
Contributor

@yskopets I can work on this

@yskopets
Copy link
Contributor Author

yskopets commented Oct 7, 2019 •
edited
Loading

@pradeepmurugesan Hi!

Thanks a lot for you interest in Kuma! We will greatly appreciate your contribution.

I've updated description to clarify the scope of the task.

Feel free to ask any questions along the way (either here or on Slack).

Good luck!

@yskopets yskopets added kumactl good first issue Good for newcomers and removed help wanted labels Oct 7, 2019
@subnetmarco
Copy link
Contributor

Hi @pradeepmurugesan! How's progress on this PR going? Let us know if you need any help from our side.

@pradeepmurugesan
Copy link
Contributor

Hey @subnetmarco .. Thanks for checking. Working on the issue.. Will be a bit slow this week. Here is my work so far. Draft PR. https://github.com/Kong/kuma/pull/343

pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 15, 2019
@pradeepmurugesan
feat(kumactl) add kumactl delete command
473234d 
Implemented the support for delete command. The delete command takes the mesh name as a parameter.
Check if the the given mesh name exists and then delete.

* returns an error in case of no mesh with the given name.

Fix kumahq#279
@pradeepmurugesan pradeepmurugesan mentioned this issue Oct 15, 2019
Merged
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 16, 2019
@pradeepmurugesan
feat(kumactl) add kumactl delete command
fefcbf1 
Implemented the support for delete command. The delete command takes the mesh name as a parameter.
Check if the the given mesh name exists and then delete.

* returns an error in case of no mesh with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 16, 2019
@pradeepmurugesan
feat(kumactl) add kumactl delete command
387ff9a 
Implemented the support for delete command. The delete command takes the mesh name as a parameter.
Check if the the given mesh name exists and then delete.

* returns an error in case of no mesh with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 16, 2019
@pradeepmurugesan
feat(kumactl) add kumactl delete command
a123085 
Implemented the support for delete command. The delete command takes the mesh name as a parameter.
Check if the the given mesh name exists and then delete.

* returns an error in case of no mesh with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 16, 2019
@pradeepmurugesan
feat(kumactl) add kumactl delete command
5f2cad4 
Implemented the support for delete command. The delete command takes the mesh name as a parameter.
Check if the the given mesh name exists and then delete.

* returns an error in case of no mesh with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 16, 2019
@pradeepmurugesan
feat(kumactl) add kumactl delete command
ae78bee 
Implemented the support for delete command. The delete command takes the mesh name as a parameter.
Check if the the given mesh name exists and then delete.

* returns an error in case of no mesh with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 17, 2019
@pradeepmurugesan
refactor(kumactl) generalized the delete command in order to use for …
41ba22a 
…all resource types

Right now the design is to handle the resource types via subcommands. Refactored so that the delete command accepts a resourceType arg.
Based on the passed resource type arg the corresponding resource will be deleted.

* returns an error in case of no mesh with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 17, 2019
@pradeepmurugesan
refactor(kumactl) generalized the delete command in order to use for …
f505a47 
…all resource types

Right now the design is to handle the resource types via subcommands. Refactored so that the delete command accepts a resourceType arg.
Based on the passed resource type arg the corresponding resource will be deleted.

* returns an error in case of no mesh with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 17, 2019
@pradeepmurugesan
feat(kumactl) add support for deleting dataplane
15c665f 
Implemented the support for deleting dataplane. Check if the the given dataplane exists and thdataplane.

* returns an error in case of no dataplane with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 17, 2019
@pradeepmurugesan
feat(kumactl) add support for deleting proxytemplate
ef37497 
Implemented the support for deleting proxytemplate. Check if the the given proxytemplate exists and then delete.

* returns an error in case of no proxytemplate with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 17, 2019
@pradeepmurugesan
feat(kumactl) add support for deleting traffic-log
ae25b0d 
Implemented the support for deleting traffic-log. Check if the the given traffic-log exists and then delete.

* returns an error in case of no traffic-log with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 17, 2019
@pradeepmurugesan
feat(kumactl) add support for deleting trafficpermission
a2e62e8 
Implemented the support for deleting trafficpermission. Check if the the given trafficpermission exists and then delete.

* returns an error in case of no trafficpermission with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 22, 2019
@pradeepmurugesan
feat(kumactl) add kumactl delete command
ff3dc9f 
Implemented the support for delete command. The delete command takes the mesh name as a parameter.
Check if the the given mesh name exists and then delete.

* returns an error in case of no mesh with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 22, 2019
@pradeepmurugesan
refactor(kumactl) generalized the delete command in order to use for …
1833895 
…all resource types

Right now the design is to handle the resource types via subcommands. Refactored so that the delete command accepts a resourceType arg.
Based on the passed resource type arg the corresponding resource will be deleted.

* returns an error in case of no mesh with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 22, 2019
@pradeepmurugesan
feat(kumactl) add support for deleting dataplane
64bac30 
Implemented the support for deleting dataplane. Check if the the given dataplane exists and thdataplane.

* returns an error in case of no dataplane with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 22, 2019
@pradeepmurugesan
feat(kumactl) add support for deleting proxytemplate
8c2a042 
Implemented the support for deleting proxytemplate. Check if the the given proxytemplate exists and then delete.

* returns an error in case of no proxytemplate with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 22, 2019
@pradeepmurugesan
feat(kumactl) add support for deleting traffic-log
e8d570b 
Implemented the support for deleting traffic-log. Check if the the given traffic-log exists and then delete.

* returns an error in case of no traffic-log with the given name.

Fix kumahq#279
pradeepmurugesan added a commit to pradeepmurugesan/kuma that referenced this issue Oct 22, 2019
@pradeepmurugesan
feat(kumactl) add support for deleting trafficpermission
39548e1 
Implemented the support for deleting trafficpermission. Check if the the given trafficpermission exists and then delete.

* returns an error in case of no trafficpermission with the given name.

Fix kumahq#279
@yskopets
Copy link
Contributor Author

@pradeepmurugesan Thanks a lot for your contribution!

@yskopets yskopets added this to the 0.3.0 milestone Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pradeepmurugesan pradeepmurugesan

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

add kumactl delete command pradeepmurugesan/kuma
3 participants
@pradeepmurugesan @subnetmarco @yskopets