Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal error: concurrent map writes on kuma 1.2.3 #2566

Closed
jgrund opened this issue Aug 14, 2021 · 1 comment
Closed

fatal error: concurrent map writes on kuma 1.2.3 #2566

jgrund opened this issue Aug 14, 2021 · 1 comment
Assignees

Comments

@jgrund
Copy link

jgrund commented Aug 14, 2021

Summary

I am seeing the following error fairly frequently when many dataplanes report in for the first time:

fatal error: concurrent map writes

Including the dump from when this occurs:

https://gist.githubusercontent.com/jgrund/18413f8209173316b375b91753e401c7/raw/042635c17995736feb7d2088379e4e5bce32abd7/kuma-1.2.3-dump

Additional Details & Logs

  • Version: kuma 1.2.3
  • Configuration: Universal
  • Platform and Operating System: Centos 7.9
@jpeach
Copy link
Contributor

jpeach commented Aug 15, 2021

Aug 14 17:20:36 node1 kuma-cp[17624]: fatal error: concurrent map writes
Aug 14 17:20:36 node1 kuma-cp[17624]: goroutine 87718 [running]:
Aug 14 17:20:36 node1 kuma-cp[17624]: runtime.throw(0x27813f1, 0x15)
Aug 14 17:20:36 node1 kuma-cp[17624]: /usr/lib/golang/src/runtime/panic.go:1117 +0x72 fp=0xc003f09420 sp=0xc003f093f0 pc=0x4384f2
Aug 14 17:20:36 node1 kuma-cp[17624]: runtime.mapassign(0x2296de0, 0xc000cb02a0, 0xc003f09508, 0x0)
Aug 14 17:20:36 node1 kuma-cp[17624]: /usr/lib/golang/src/runtime/map.go:585 +0x5aa fp=0xc003f094a0 sp=0xc003f09420 pc=0x41006a
Aug 14 17:20:36 node1 kuma-cp[17624]: github.com/kumahq/kuma/pkg/xds/server/callbacks.(*DataplaneLifecycle).register(0xc0009fe1c0, 0x2a, 0xc001f0f200, 0x7, 0xc001f0f208, 0x32, 0x0, 0x0, 0xc001c74460, 0x91, ...)
Aug 14 17:20:36 node1 kuma-cp[17624]: /__w/pkg-kuma/pkg-kuma/rpm/BUILD/kuma-1.2.3/pkg/xds/server/callbacks/dataplane_lifecycle.go:53 +0x2f0 fp=0xc003f09538 sp=0xc003f094a0 pc=0x1fe10d0
Aug 14 17:20:36 node1 kuma-cp[17624]: github.com/kumahq/kuma/pkg/xds/server/callbacks.(*DataplaneLifecycle).OnProxyConnected(0xc0009fe1c0, 0x2a, 0xc001f0f200, 0x7, 0xc001f0f208, 0x32, 0x33db278, 0xc000ff96b0, 0x0, 0x0, ...)
Aug 14 17:20:36 node1 kuma-cp[17624]: /__w/pkg-kuma/pkg-kuma/rpm/BUILD/kuma-1.2.3/pkg/xds/server/callbacks/dataplane_lifecycle.go:39 +0xa5 fp=0xc003f095e8 sp=0xc003f09538 pc=0x1fe0cc5
Aug 14 17:20:36 node1 kuma-cp[17624]: github.com/kumahq/kuma/pkg/xds/server/callbacks.(*xdsCallbacks).OnStreamRequest(0xc0009fe200, 0x2a, 0x33f0b58, 0xc0006297c0, 0x0, 0x0)
Aug 14 17:20:36 node1 kuma-cp[17624]: /__w/pkg-kuma/pkg-kuma/rpm/BUILD/kuma-1.2.3/pkg/xds/server/callbacks/dataplane_callbacks.go:118 +0x475 fp=0xc003f097c8 sp=0xc003f095e8 pc=0x1fe0775
Aug 14 17:20:36 node1 kuma-cp[17624]: github.com/kumahq/kuma/pkg/util/xds/v3.(*adapterCallbacks).OnStreamRequest(0xc000688900, 0x2a, 0xc0031e7f00, 0x0, 0x0)

@jpeach jpeach self-assigned this Aug 15, 2021
@jpeach jpeach closed this as completed in 1591de6 Aug 16, 2021
mergify bot pushed a commit that referenced this issue Aug 16, 2021
In the DataplaneLifecycle tracker, consistently lock the map that
tracks whether the dataplane has been successfully registered.

This fixes #2566.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 1591de6)
jpeach added a commit that referenced this issue Aug 16, 2021
In the DataplaneLifecycle tracker, consistently lock the map that
tracks whether the dataplane has been successfully registered.

This fixes #2566.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 1591de6)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants