Skip to content

Commit

Permalink
fix(dns) allow resolution of service names with "." (#1448)
Browse files Browse the repository at this point in the history
When specifying a `kuma.io/service` with a "." DNS resolution would not work
because it would only look at the first part of the DNS name.
This would also cause `foo.bar.mesh` and `foo.mesh` to resolve to the same thing
which may give a false sense of isolation of meshes in the DNS
We now only strips the last part of the DNS name if it matches the `.mesh` domain suffix.

Signed-off-by: Charly Molter <charly@koyeb.com>
  • Loading branch information
Charly Molter authored Jan 20, 2021
1 parent 004a4e1 commit de170f1
Show file tree
Hide file tree
Showing 4 changed files with 147 additions and 10 deletions.
Loading

0 comments on commit de170f1

Please sign in to comment.